Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields: Fix devtools warning while enabling/disabling panel #4955

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

cezaraugusto
Copy link
Contributor

Fix brave/brave-browser#6828

Submitter Checklist:

Test Plan:

  1. Go to brave://inspect#extensions, open Shields (named Brave) devtools
  2. Visit https://brave.com/
  3. Disable/enable Shields
  4. No warning/error should be logged to the console
  5. Shields should still be able to block resources if enabled/unblock if disabled

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@cezaraugusto cezaraugusto self-assigned this Mar 16, 2020
@bsclifton bsclifton removed the request for review from petemill March 30, 2020 17:48
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this works great! Nice ❤️

@bsclifton
Copy link
Member

bsclifton commented Mar 31, 2020

Gonna give this a rebase and let it go through CI 👍
edit: had to delete brave-browser branch too

@bsclifton
Copy link
Member

CI looks good - only failed test is something we're looking into with brave/brave-browser#8956

@bsclifton bsclifton merged commit 8ca8d5f into master Apr 1, 2020
@bsclifton bsclifton deleted the ca-6828 branch April 1, 2020 05:58
@bbondy bbondy added this to the 1.8.x - Release milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd" errors when disabling/enabling shields
3 participants