-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shows only completed tips in tip list #5121
Conversation
@@ -572,7 +572,7 @@ void DatabaseContributionInfo::GetOneTimeTips( | |||
"ON spi.publisher_key = pi.publisher_id " | |||
"WHERE strftime('%%m', datetime(ci.created_at, 'unixepoch')) = ? AND " | |||
"strftime('%%Y', datetime(ci.created_at, 'unixepoch')) = ? " | |||
"AND ci.type = ?", | |||
"AND ci.type = ? AND ci.step = ?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change fixes tip table display
@@ -1189,6 +1189,24 @@ void Contribution::OnExternalWalletServerPublisherInfo( | |||
return; | |||
} | |||
|
|||
if (info->status != ledger::PublisherStatus::VERIFIED) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change fixes pending contribution not logged
Verified using
|
Resolves brave/brave-browser#8945
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.