Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shows only completed tips in tip list (uplift to 1.7.x) #5135

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Shows only completed tips in tip list (uplift to 1.7.x) #5135

merged 1 commit into from
Apr 1, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 1, 2020 •
edited by kjozwiak
Loading

Uplift of #5121

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 1.7.x - Beta milestone Apr 1, 2020
@NejcZdovc NejcZdovc requested a review from a team April 1, 2020 16:03
@NejcZdovc NejcZdovc self-assigned this Apr 1, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Apr 1, 2020

Travis is failing TEST_SUITE=test-security due to the minimist npm package being vulnerable. It's a known issue as per brave/brave-browser#8722 and doesn't block the PR from being uplifted.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 1, 2020

QA ran through the original PR on Nightly as per #5121 (comment) 👍

kjozwiak
kjozwiak approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak closed this Apr 1, 2020
@kjozwiak kjozwiak reopened this Apr 1, 2020
@kjozwiak kjozwiak merged commit 5bd5736 into 1.7.x Apr 1, 2020
@kjozwiak kjozwiak deleted the tip-table-1.7 branch April 1, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @kjozwiak