Disable password sign in promo disregarding sync status #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
approved these changes
Oct 1, 2019
brave-builds
pushed a commit
that referenced
this pull request
Oct 2, 2019
brave-builds
pushed a commit
that referenced
this pull request
Oct 2, 2019
brave-builds
pushed a commit
that referenced
this pull request
Oct 2, 2019
mariospr
added a commit
that referenced
this pull request
Jul 22, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mariospr
added a commit
that referenced
this pull request
Jul 27, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mariospr
added a commit
that referenced
this pull request
Jul 28, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mkarolin
pushed a commit
that referenced
this pull request
Jul 29, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mariospr
added a commit
that referenced
this pull request
Jul 30, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mkarolin
pushed a commit
that referenced
this pull request
Aug 2, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mariospr
added a commit
that referenced
this pull request
Aug 4, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mkarolin
pushed a commit
that referenced
this pull request
Aug 5, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mkarolin
pushed a commit
that referenced
this pull request
Aug 7, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mariospr
added a commit
that referenced
this pull request
Aug 9, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mariospr
added a commit
that referenced
this pull request
Aug 10, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mkarolin
pushed a commit
that referenced
this pull request
Aug 12, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mkarolin
pushed a commit
that referenced
this pull request
Aug 16, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
mkarolin
pushed a commit
that referenced
this pull request
Aug 18, 2021
The signin promo has been entirely deleted from upstream, so we neither need nor can keep this code around, as it won't do anything other than breaking the build. This is essentially a revert of github.com//pull/3566 Chromium change: https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468 Author: Marc Treib <[email protected]> Date: Mon Jul 12 09:47:19 2021 +0000 B4P cleanup, part 3: Delete Passwords Signin promo This promo is not used anymore and so can be deleted. This CL also deletes the related helper ShouldShowChromeSignInPasswordPromo and deprecates the related prefs. Bug: 1108738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#5849
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Offer to save passwordsis enabled in brave://settings/passwords and setup brave sync
4. There shouldn't be any prompt asking to sign in, now click on the key icon, we should seeReviewer Checklist:
After-merge Checklist:
changes has landed on.