Skip to content

Commit

Permalink
Drop changes to disable the sign in prompt from password signin promo
Browse files Browse the repository at this point in the history
The signin promo has been entirely deleted from upstream, so we neither
need nor can keep this code around, as it won't do anything other than
breaking the build.

This is essentially a revert of github.com//pull/3566

Chromium change:

https://chromium.googlesource.com/chromium/src/+/41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468

commit 41d144e7c8dbe2b5a59ff87b0d45566fb3a0c468
Author: Marc Treib <[email protected]>
Date:   Mon Jul 12 09:47:19 2021 +0000

    B4P cleanup, part 3: Delete Passwords Signin promo

    This promo is not used anymore and so can be deleted.
    This CL also deletes the related helper
    ShouldShowChromeSignInPasswordPromo and deprecates the related prefs.

    Bug: 1108738
  • Loading branch information
mariospr authored and mkarolin committed Aug 16, 2021
1 parent 7007dad commit 11d7891
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 98 deletions.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ test("brave_unit_tests") {
"//brave/chromium_src/chrome/browser/signin/account_consistency_disabled_unittest.cc",
"//brave/chromium_src/components/autofill/core/browser/autofill_experiments_unittest.cc",
"//brave/chromium_src/components/metrics/enabled_state_provider_unittest.cc",
"//brave/chromium_src/components/password_manager/core/browser/password_bubble_experiment_unittest.cc",
"//brave/chromium_src/components/variations/service/field_trial_unittest.cc",
"//brave/chromium_src/components/version_info/brave_version_info_unittest.cc",
"//brave/chromium_src/net/cookies/brave_canonical_cookie_unittest.cc",
Expand Down

0 comments on commit 11d7891

Please sign in to comment.