Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable password sign in promo disregarding sync status (uplift to 0.71.x) #3584

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Disable password sign in promo disregarding sync status (uplift to 0.71.x) #3584

merged 1 commit into from
Oct 2, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 2, 2019 •
edited by bsclifton
Loading

Uplift of #3566
Fixes brave/brave-browser#5849

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Oct 2, 2019
@brave-builds brave-builds added this to the 0.71.x - Dev milestone Oct 2, 2019
@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 2, 2019
@bsclifton
Copy link
Member

Intermittent error seen during macOS unit test; re-running CI for macOS only

@bsclifton
Copy link
Member

Re-run ran into the same error:
error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: brave_browser_tests (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

which is not related. Should be good to go 👍

bsclifton
bsclifton approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 1705ec8 into 0.71.x Oct 2, 2019
@bsclifton bsclifton deleted the pr3566_pw-signin-promo_0.71.x branch October 2, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

@bbondy bbondy Awaiting requested review from bbondy

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @bsclifton @brave-browser-releases