Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "sign in to Brave" dialog when saving passwords #5849

Closed
Brave-Matt opened this issue Aug 30, 2019 · 4 comments · Fixed by brave/brave-core#3566
Closed

Remove "sign in to Brave" dialog when saving passwords #5849

Brave-Matt opened this issue Aug 30, 2019 · 4 comments · Fixed by brave/brave-core#3566

Comments

@Brave-Matt
Copy link

Brave-Matt commented Aug 30, 2019

Test plan

See brave/brave-core#3566

Description

Brave prompts users to "sign in to" Brave to get your passwords on all devices when saving a new password to the built-in PW manager. This is likely triggered due to Chrome's Sync functionality.

image

Steps to Reproduce

  1. Visit a website you have an account on or register for an account
  2. When credentials are entered, select Save when asked if you'd like to save creds.
  3. Observe notification pictured above.

Actual result:

[See image]

Expected result:

Should not see the prompt to "sign in to Brave".

Reproduces how often:

Easily/Always

Brave version (brave://version info)

Version 0.70.78 Chromium: 76.0.3809.132 (Official Build) dev (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? ❌
  • Can you reproduce this issue with the beta channel? ❌
  • Can you reproduce this issue with the dev channel? ✅
  • Can you reproduce this issue with the nightly channel? ❌

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Yes (cause Chrome has Sync)
@bsclifton bsclifton added bug priority/P2 A bad problem. We might uplift this to the next planned release. feature/password-manager labels Sep 3, 2019
@LaurenWags
Copy link
Member

Reproduced with

Brave 0.68.141 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

@arisAlexis
Copy link

clicking sign-in redirects you to : https://no-thanks.invalid/signin/chrome/sync?ssp=1&continue=https%3A%2F%2Fwww.google.com%2F which is very confusing for new users

@bsclifton
Copy link
Member

cc: @darkdh I think this may have regressed when landing the Syncer work (similar to how #5839 regressed)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 3, 2019

Verification passed on

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants