-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "sign in to Brave" dialog when saving passwords #5849
Comments
Reproduced with
|
clicking sign-in redirects you to : https://no-thanks.invalid/signin/chrome/sync?ssp=1&continue=https%3A%2F%2Fwww.google.com%2F which is very confusing for new users |
Verification passed on
Verification passed on
Verified passed with
|
Test plan
See brave/brave-core#3566
Description
Brave prompts users to "sign in to" Brave to get your passwords on all devices when saving a new password to the built-in PW manager. This is likely triggered due to Chrome's Sync functionality.
Steps to Reproduce
Save
when asked if you'd like to save creds.Actual result:
[See image]
Expected result:
Should not see the prompt to "sign in to Brave".
Reproduces how often:
Easily/Always
Brave version (brave://version info)
Version 0.70.78 Chromium: 76.0.3809.132 (Official Build) dev (64-bit)
Version/Channel Information:
Other Additional Information:
The text was updated successfully, but these errors were encountered: