Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave VPN card widget in NTP (uplift to 1.74.x) #26680

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Brave VPN card widget in NTP (uplift to 1.74.x) #26680

merged 7 commits into from
Dec 4, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 21, 2024 •
edited by kjozwiak
Loading

Uplift of #26189 #26496 #26689 #26743 #26745 #26746 #26765
Resolves brave/brave-browser#41778
Resolves brave/brave-browser#42228
Resolves brave/brave-browser#42227
Resolves brave/brave-browser#42446
Resolves brave/brave-browser#42500
Resolves brave/brave-browser#42503
Resolves brave/brave-browser#42511
Resolves brave/brave-browser#42543

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong simonhong self-assigned this Nov 21, 2024
@simonhong simonhong requested a review from a team as a code owner November 21, 2024 06:53
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 21, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@simonhong
Merge pull request #26689 from brave/vpn_card_group_policy
842deff 
Hide NTP VPN card when its group policy is disabled
@simonhong
Merge pull request #26743 from brave/update_vpn_card_option_image
c7f64b9 
Updated vpn card option image in NTP
@simonhong
Merge pull request #26745 from brave/update_vpn_product_title
d0bdfdd 
Update VPN product title at vpn panel
@simonhong
Merge pull request #26746 from brave/update_trial_url_from_vpn_card
669b135 
Updated trial url from vpn card
@simonhong
Merge pull request #26765 from brave/fix_vpn_icon_size_vpn_card
0c8cd26 
Fixed bottom of vpn icon of vpn card was clipped
@rebron rebron added this to the 1.74.x - Beta milestone Dec 3, 2024
kjozwiak
kjozwiak approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.74.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #26189 (comment), #26189 (comment), #26189 (comment), #26689 (comment), #26743 (comment), #26745 (comment), #26746 (comment), #26765 (comment).

@kjozwiak kjozwiak merged commit bf3fd74 into 1.74.x Dec 4, 2024
15 checks passed
@kjozwiak kjozwiak deleted the ntp_vpn_card_widget_1.74 branch December 4, 2024 20:15
@brave-builds
Copy link
Collaborator

Released in v1.74.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.74.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@simonhong @brave-builds @kjozwiak @rebron