Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated trial url from vpn card #26746

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Updated trial url from vpn card #26746

merged 1 commit into from
Nov 26, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 26, 2024 •
edited
Loading

fix brave/brave-browser#42511

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

@simonhong simonhong self-assigned this Nov 26, 2024
@simonhong simonhong merged commit dd36440 into master Nov 26, 2024
18 checks passed
@simonhong simonhong deleted the update_trial_url_from_vpn_card branch November 26, 2024 22:57
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 26, 2024
simonhong added a commit that referenced this pull request Nov 26, 2024
@simonhong
Merge pull request #26746 from brave/update_trial_url_from_vpn_card
6a11b8a 
Updated trial url from vpn card
simonhong added a commit that referenced this pull request Nov 26, 2024
@simonhong
Merge pull request #26746 from brave/update_trial_url_from_vpn_card
669b135 
Updated trial url from vpn card
This was referenced Nov 26, 2024
Merged
Merged
@brave-builds
Copy link
Collaborator

Released in v1.75.54

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.75.55 Chromium: 131.0.6778.85 (Official Build) nightly (64-bit)
-- | --
Revision | 3cc3ba11608e3bbbf9e053bdd032ec05e2a4db7f
OS | Windows 11 Version 24H2 (Build 26100.2314)
  1. Installed 1.75.55
  2. launched Brave
  3. clicked Start free trial button in the Brave VPN Widget
  4. confirmed https://account.brave.com/?intent=checkout&product=vpn page loaded
  5. entered an email address and clicked Start free trial button
  6. confirmed secure login link is created
  7. clicked the link
  8. navigated stripe checkout page as expected
step 3 step 4 step 5 step 9
image image image image

kjozwiak pushed a commit that referenced this pull request Dec 4, 2024
@simonhong
Brave VPN card widget in NTP (uplift to 1.74.x) (#26680)
bf3fd74 
* Merge pull request #26189 from brave/brave_vpn_ntp_widget_demo

Brave VPN card widget in NTP

* Merge pull request #26496 from brave/follow_up_brave_vpn_card

F/U vpn card widgets in NTP

* Merge pull request #26689 from brave/vpn_card_group_policy

Hide NTP VPN card when its group policy is disabled

* Merge pull request #26743 from brave/update_vpn_card_option_image

Updated vpn card option image in NTP

* Merge pull request #26745 from brave/update_vpn_product_title

Update VPN product title at vpn panel

* Merge pull request #26746 from brave/update_trial_url_from_vpn_card

Updated trial url from vpn card

* Merge pull request #26765 from brave/fix_vpn_icon_size_vpn_card

Fixed bottom of vpn icon of vpn card was clipped
kjozwiak pushed a commit that referenced this pull request Dec 4, 2024
@simonhong
Brave VPN card widget in NTP (uplift to 1.73.x) (#26681)
354d3a2 
* Merge pull request #26299 from brave/introduce_brave_vpn_controller

Added BraveVPNController to BrowserWindowFeatures

* Make vpn bubble start with server selection (#26310)

fix brave/brave-browser#41991

NTP VPN Widget card will use this.

* Merge pull request #26189 from brave/brave_vpn_ntp_widget_demo

Brave VPN card widget in NTP

* Merge pull request #26496 from brave/follow_up_brave_vpn_card

F/U vpn card widgets in NTP

* Fixed build failure

* Merge pull request #26689 from brave/vpn_card_group_policy

Hide NTP VPN card when its group policy is disabled

* Merge pull request #26743 from brave/update_vpn_card_option_image

Updated vpn card option image in NTP

* Merge pull request #26745 from brave/update_vpn_product_title

Update VPN product title at vpn panel

* Merge pull request #26746 from brave/update_trial_url_from_vpn_card

Updated trial url from vpn card

* Merge pull request #26765 from brave/fix_vpn_icon_size_vpn_card

Fixed bottom of vpn icon of vpn card was clipped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.75.x - Nightly
Development

Successfully merging this pull request may close these issues.

Follow up [PR 26189] - Incorrect page, secure login link, loaded when clicked Start free trial button.
4 participants
@simonhong @brave-builds @MadhaviSeelam @fallaciousreasoning