-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide NTP VPN card when its group policy is disabled #26689
Conversation
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "policy" and so security team members have been added as reviewers to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Hide NTP VPN card when its group policy is disabled
Hide NTP VPN card when its group policy is disabled
Released in v1.75.44 |
Verification
Please see additional steps on how to add/remove templates: brave/brave-browser#26502
|
* Merge pull request #26189 from brave/brave_vpn_ntp_widget_demo Brave VPN card widget in NTP * Merge pull request #26496 from brave/follow_up_brave_vpn_card F/U vpn card widgets in NTP * Merge pull request #26689 from brave/vpn_card_group_policy Hide NTP VPN card when its group policy is disabled * Merge pull request #26743 from brave/update_vpn_card_option_image Updated vpn card option image in NTP * Merge pull request #26745 from brave/update_vpn_product_title Update VPN product title at vpn panel * Merge pull request #26746 from brave/update_trial_url_from_vpn_card Updated trial url from vpn card * Merge pull request #26765 from brave/fix_vpn_icon_size_vpn_card Fixed bottom of vpn icon of vpn card was clipped
* Merge pull request #26299 from brave/introduce_brave_vpn_controller Added BraveVPNController to BrowserWindowFeatures * Make vpn bubble start with server selection (#26310) fix brave/brave-browser#41991 NTP VPN Widget card will use this. * Merge pull request #26189 from brave/brave_vpn_ntp_widget_demo Brave VPN card widget in NTP * Merge pull request #26496 from brave/follow_up_brave_vpn_card F/U vpn card widgets in NTP * Fixed build failure * Merge pull request #26689 from brave/vpn_card_group_policy Hide NTP VPN card when its group policy is disabled * Merge pull request #26743 from brave/update_vpn_card_option_image Updated vpn card option image in NTP * Merge pull request #26745 from brave/update_vpn_product_title Update VPN product title at vpn panel * Merge pull request #26746 from brave/update_trial_url_from_vpn_card Updated trial url from vpn card * Merge pull request #26765 from brave/fix_vpn_icon_size_vpn_card Fixed bottom of vpn icon of vpn card was clipped
fix brave/brave-browser#42446
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See the linked issue