Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN card should be at the top when enabled from customize option #42228

Closed
1 of 6 tasks
simonhong opened this issue Nov 12, 2024 · 0 comments · Fixed by brave/brave-core#26496
Closed
1 of 6 tasks

VPN card should be at the top when enabled from customize option #42228

simonhong opened this issue Nov 12, 2024 · 0 comments · Fixed by brave/brave-core#26496
Assignees
@simonhong
Labels
feature/vpn OS/Desktop OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.73.x - Release #5

Comments

@simonhong
Copy link
Member

Description

VPN card widget should be at the top after it's re-added from customize option

Steps to reproduce

  1. Hide rewards card and hide vpn card from customize option
  2. Show rewards and then show vpn card from customize

Actual result

vpn card should be in front of other cards

Expected result

It's behind the others

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.75.9 Chromium: 131.0.6778.39 (Official Build) nightly (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @rebron @bsclifton @brave/qa-team
Set this as qa/no as whole vpn card QA can be done with #41778
@simonhong simonhong self-assigned this Nov 12, 2024
simonhong added a commit to brave/brave-core that referenced this issue Nov 12, 2024
@simonhong
Put vpn card in front of others when it's readded
f26aa98 
fix github.com/brave/brave-browser/issues/42228
@simonhong simonhong mentioned this issue Nov 12, 2024
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Nov 13, 2024
@simonhong
Put vpn card in front of others when it's readded
6f5b9ad 
fix github.com/brave/brave-browser/issues/42228
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 13, 2024
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 21, 2024
This was referenced Nov 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/vpn OS/Desktop OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.73.x - Release #5
Development

Successfully merging a pull request may close this issue.

F/U vpn card widgets in NTP brave/brave-core
3 participants
@rebron @simonhong @brave-builds