-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply brave version to chrome/VERSION #258
Conversation
Mac signing is failed when
|
On windows, install/update works. On MacOS, update test is failed. |
#include "gen/components/version_info/version_info_values.h" | ||
|
||
#define CHROMIUM_VERSION 67,0,3396,103 | ||
#define CHROMIUM_VERSION_STRING "67.0.3396.103" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this just be a generated file instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly from brave/brave-browser after init?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or even better by using gen dir with brave-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do changes in a followup. I asked @RyanJarv and he said he could try to see if it works once merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do changes in a followup. I asked @RyanJarv and he said he could try to see if it works once merged.
@@ -0,0 +1,4 @@ | |||
#include "gen/components/version_info/version_info_values.h" | |||
|
|||
#define CHROMIUM_VERSION 67,0,3396,103 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is CHROMIUM_VERSION
needed?
Comments are addressed by #260 |
Set brave version to chrome/VERSION.
Using chromium and brave version both internally can case version inconsistency and make windows update logic complex.
To simplify use brave version and only visible chromium version in some places such as about/version and user agent.
#249 should be reverted for using this.
Close brave/brave-browser#553
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: