-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply brave version to chrome/VERSION #258
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#include "gen/components/version_info/version_info_values.h" | ||
|
||
#define CHROMIUM_VERSION 67,0,3396,103 | ||
#define CHROMIUM_VERSION_STRING "67.0.3396.103" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can this just be a generated file instead? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Possibly from brave/brave-browser after init? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. or even better by using gen dir with brave-core |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
diff --git a/chrome/VERSION b/chrome/VERSION | ||
index 3c03c34dbf7ecdf3673cb796c44c769bc14b1dba..43f26ebad722c3ea1e62f4280e00b7531efeb52f 100644 | ||
--- a/chrome/VERSION | ||
+++ b/chrome/VERSION | ||
@@ -1,4 +1,4 @@ | ||
MAJOR=67 | ||
MINOR=0 | ||
-BUILD=3396 | ||
-PATCH=103 | ||
+BUILD=50 | ||
+PATCH=10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is
CHROMIUM_VERSION
needed?