Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply brave version to update on Mac #249

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jul 12, 2018

This version will be used by sparkle update to check version.

Confirmed that user agent string is not affected by this change.

Issue brave/brave-browser#396

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@simonhong simonhong self-assigned this Jul 12, 2018
@simonhong simonhong changed the title Apply brave version to Info.plist Apply brave version to update on Mac Jul 12, 2018
This version will be used by sparkle update to check version.
@bbondy bbondy merged commit a9e32e6 into master Jul 12, 2018
@simonhong simonhong deleted the apply_brave_version_on_mac branch August 19, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants