Prepare for dev release #396

simonhong · 2018-06-22T06:19:58Z

RyanJarv · 2018-06-23T03:47:18Z

Few things to add that I'll be working on:

Internal build ready omaha-server (Internal build release omaha-server#1)
Omaha build environment (Internal build release omaha-build#4)
Security review

simonhong · 2018-06-29T07:11:13Z

Mac channel: Determined in build time.
Mac install dir : replace target Brave.app to channel dependent name like Brave-Browser-Nightly in brave/build/mac/BUILD.gn. Then it copied to /Application/Brave-Browser-Nightly

Linux channel: yarn create_dist Release creates all three versions (stable, beta, unstable(dev)) with commenting out renameLinuxDistro(options) in createDist.js.
Linux install dir:

/opt/brave.com/brave
/opt/brave.com/brave-beta
/opt/brave.com/brave-beta-unstable/

Window channel: determined by installed path on runtime
Window install dir: need to check how omaha installer or mini_installer handles

simonhong · 2018-07-02T03:35:03Z

When executing windows silent installer with additional install switch such as --chrome-dev, --chrome--beta or --chrome-sxs, it is installed into expected install dir. (EX, C:\Users\XXX\AppData\Local\BraveSoftware\Brave-Browser-Nightly).

Problems after silent install. (fixed by brave/brave-core#214)

Not visible in uninstall list. (stable version is visible)
=> Reason: empty DisplayName property in HCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\BraveSoftware Brave-Browser-Nightly
Empty name in desktop shortcut

RyanJarv · 2018-07-03T06:39:18Z

On the initial overview of the unofficial release sec review (https://github.com/brave/internal/issues/378) it sounds like we want to have the open sparkle issues resolved as well.

@bkero is looking into brave/Sparkle#5 some more to figure out what the tradeoffs are there.

@simonhong do you think you have time to take brave/Sparkle#4?

simonhong · 2018-07-05T10:56:24Z

@simonhong do you think you have time to take brave/Sparkle#4?

Ok, After fixing multiple install bug(#469) that is the only remained issue for binary release, I'll take a look.

RyanJarv · 2018-07-09T18:49:17Z

Sorry late update here, we're ok on brave/Sparkle#4 and brave/Sparkle#5 for now. We'll just need to come back to these for the official release.

simonhong · 2018-07-09T23:56:21Z

Title is changed because most of items in this issue are also needed for dev channel release.

simonhong · 2018-07-10T03:15:10Z

Install multiple release on MacOS item is deleted from this PR because we can open dev release w/o it.
It should be resolved before we open multiple channels.

So, I'm taking a look windows installer.

simonhong · 2018-07-10T08:12:29Z

About version, windows installer sets its version to register(pv) and its version should be same in version value of server.

simonhong · 2018-07-11T01:02:55Z

Hmm, installer is tightly coupled with chrome/VERSION than expected

simonhong · 2018-07-13T02:01:18Z

When runs brave after install with brave/brave-core#250, it failed to run.
Below is sxstrace.exe result. Where 67.0.3396.103 came from...?
brave.exe property has 0.50.8.0 value.

=================
Begin Activation Context Generation.
Input Parameter:
	Flags = 0
	ProcessorArchitecture = AMD64
	CultureFallBacks = en-US;en
	ManifestPath = C:\Users\simon\AppData\Local\BraveSoftware\Brave-Browser\Application\brave.exe
	AssemblyDirectory = C:\Users\simon\AppData\Local\BraveSoftware\Brave-Browser\Application\
	Application Config File = 
-----------------
INFO: Parsing Manifest File C:\Users\simon\AppData\Local\BraveSoftware\Brave-Browser\Application\brave.exe.
	INFO: Manifest Definition Identity is (null).
	INFO: Reference: Microsoft.Windows.Common-Controls,language="&#x2a;",processorArchitecture="&#x2a;",publicKeyToken="6595b64144ccf1df",type="win32",version="6.0.0.0"
	INFO: Reference: 67.0.3396.103,language="&#x2a;",type="win32",version="67.0.3396.103"
INFO: Resolving reference Microsoft.Windows.Common-Controls,language="&#x2a;",processorArchitecture="&#x2a;",publicKeyToken="6595b64144ccf1df",type="win32",version="6.0.0.0".
	INFO: Resolving reference for ProcessorArchitecture AMD64.
		INFO: Resolving reference for culture en-US.
			INFO: Applying Binding Policy.
				INFO: No publisher policy found.
				INFO: No binding policy redirect found.
			INFO: Begin assembly probing.
				INFO: Did not find the assembly in WinSxS.
				INFO: Attempt to probe manifest at C:\WINDOWS\assembly\GAC_64\Microsoft.Windows.Common-Controls\6.0.0.0_en-US_6595b64144ccf1df\Microsoft.Windows.Common-Controls.DLL.
				INFO: Did not find manifest for culture en-US.
			INFO: End assembly probing.
		INFO: Resolving reference for culture en.
			INFO: Applying Binding Policy.
				INFO: No publisher policy found.
				INFO: No binding policy redirect found.
			INFO: Begin assembly probing.
				INFO: Did not find the assembly in WinSxS.
				INFO: Attempt to probe manifest at C:\WINDOWS\assembly\GAC_64\Microsoft.Windows.Common-Controls\6.0.0.0_en_6595b64144ccf1df\Microsoft.Windows.Common-Controls.DLL.
				INFO: Did not find manifest for culture en.
			INFO: End assembly probing.
		INFO: Resolving reference for culture Neutral.
			INFO: Applying Binding Policy.
				INFO: Auto Servicing Policy redirected assembly version.
				INFO: Post policy assembly identity is Microsoft.Windows.Common-Controls,processorArchitecture="AMD64",publicKeyToken="6595b64144ccf1df",type="win32",version="6.0.17134.165".
			INFO: Begin assembly probing.
				INFO: Attempt to probe manifest at C:\WINDOWS\WinSxS\manifests\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.17134.165_none_fb429645306569ac.manifest.
				INFO: Manifest found at C:\WINDOWS\WinSxS\manifests\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.17134.165_none_fb429645306569ac.manifest.
			INFO: End assembly probing.
INFO: Resolving reference Microsoft.Windows.Common-Controls.mui,language="&#x2a;",processorArchitecture="AMD64",publicKeyToken="6595b64144ccf1df",type="win32",version="6.0.17134.165".
	INFO: Resolving reference for ProcessorArchitecture AMD64.
		INFO: Resolving reference for culture en-US.
			INFO: Applying Binding Policy.
				INFO: No publisher policy found.
				INFO: No binding policy redirect found.
			INFO: Begin assembly probing.
				INFO: Did not find the assembly in WinSxS.
				INFO: Attempt to probe manifest at C:\WINDOWS\assembly\GAC_64\Microsoft.Windows.Common-Controls.mui\6.0.17134.165_en-US_6595b64144ccf1df\Microsoft.Windows.Common-Controls.mui.DLL.
				INFO: Did not find manifest for culture en-US.
			INFO: End assembly probing.
		INFO: Resolving reference for culture en.
			INFO: Applying Binding Policy.
				INFO: No publisher policy found.
				INFO: No binding policy redirect found.
			INFO: Begin assembly probing.
				INFO: Did not find the assembly in WinSxS.
				INFO: Attempt to probe manifest at C:\WINDOWS\assembly\GAC_64\Microsoft.Windows.Common-Controls.mui\6.0.17134.165_en_6595b64144ccf1df\Microsoft.Windows.Common-Controls.mui.DLL.
				INFO: Did not find manifest for culture en.
			INFO: End assembly probing.
INFO: Resolving reference 67.0.3396.103,language="&#x2a;",type="win32",version="67.0.3396.103".
	INFO: Resolving reference for ProcessorArchitecture 67.0.3396.103,language="&#x2a;",type="win32",version="67.0.3396.103".
		INFO: Resolving reference for culture en-US.
			INFO: Applying Binding Policy.
				INFO: No binding policy redirect found.
			INFO: Begin assembly probing.
				INFO: Did not find the assembly in WinSxS.
				INFO: Did not find manifest for culture en-US.
			INFO: End assembly probing.
		INFO: Resolving reference for culture en.
			INFO: Applying Binding Policy.
				INFO: No binding policy redirect found.
			INFO: Begin assembly probing.
				INFO: Did not find the assembly in WinSxS.
				INFO: Did not find manifest for culture en.
			INFO: End assembly probing.
		INFO: Resolving reference for culture Neutral.
			INFO: Applying Binding Policy.
				INFO: No binding policy redirect found.
			INFO: Begin assembly probing.
				INFO: Did not find the assembly in WinSxS.
				INFO: Attempt to probe manifest at C:\Users\simon\AppData\Local\BraveSoftware\Brave-Browser\Application\67.0.3396.103.DLL.
				INFO: Attempt to probe manifest at C:\Users\simon\AppData\Local\BraveSoftware\Brave-Browser\Application\67.0.3396.103.MANIFEST.
				INFO: Attempt to probe manifest at C:\Users\simon\AppData\Local\BraveSoftware\Brave-Browser\Application\67.0.3396.103\67.0.3396.103.DLL.
				INFO: Attempt to probe manifest at C:\Users\simon\AppData\Local\BraveSoftware\Brave-Browser\Application\67.0.3396.103\67.0.3396.103.MANIFEST.
				INFO: Did not find manifest for culture Neutral.
			INFO: End assembly probing.
	ERROR: Cannot resolve reference 67.0.3396.103,language="&#x2a;",type="win32",version="67.0.3396.103".
ERROR: Activation Context generation failed.
End Activation Context Generation.

simonhong · 2018-07-16T23:54:06Z

All items are cleared.

simonhong self-assigned this Jun 22, 2018

bbondy added this to the Releasable builds milestone Jun 27, 2018

This was referenced Jun 30, 2018

Apply channel name to mac app name brave/brave-core#208

Merged

Only creates dist package for specified channel on linux brave/brave-core#209

Merged

Skip rename method of linux dist #459

Merged

simonhong mentioned this issue Jul 2, 2018

Make mini installer for non-stable channel work properly brave/brave-core#214

Merged

9 tasks

simonhong changed the title ~~Prepare for nightly release~~ Prepare for dev release Jul 9, 2018

This was referenced Jul 11, 2018

Sparkle: update server url and enable background update when browser stars brave/brave-core#242

Merged

Apply brave version to update on Mac brave/brave-core#249

Merged

Apply brave version to mini installer brave/brave-core#250

Closed

simonhong mentioned this issue Jul 16, 2018

Apply brave version to chrome/VERSION brave/brave-core#258

Merged

9 tasks

simonhong closed this as completed Jul 16, 2018

bbondy added the QA/No label Aug 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare for dev release #396

Prepare for dev release #396

simonhong commented Jun 22, 2018 •

edited

Loading

RyanJarv commented Jun 23, 2018

simonhong commented Jun 29, 2018 •

edited

Loading

simonhong commented Jul 2, 2018 •

edited

Loading

RyanJarv commented Jul 3, 2018

simonhong commented Jul 5, 2018

RyanJarv commented Jul 9, 2018

simonhong commented Jul 9, 2018

simonhong commented Jul 10, 2018

simonhong commented Jul 10, 2018 •

edited

Loading

simonhong commented Jul 11, 2018

simonhong commented Jul 13, 2018 •

edited

Loading

simonhong commented Jul 16, 2018

Prepare for dev release #396

Prepare for dev release #396

Comments

simonhong commented Jun 22, 2018 • edited Loading

Windows

MacOS

Linux

Resources

Apply brave version (#553)

RyanJarv commented Jun 23, 2018

simonhong commented Jun 29, 2018 • edited Loading

simonhong commented Jul 2, 2018 • edited Loading

RyanJarv commented Jul 3, 2018

simonhong commented Jul 5, 2018

RyanJarv commented Jul 9, 2018

simonhong commented Jul 9, 2018

simonhong commented Jul 10, 2018

simonhong commented Jul 10, 2018 • edited Loading

simonhong commented Jul 11, 2018

simonhong commented Jul 13, 2018 • edited Loading

simonhong commented Jul 16, 2018

simonhong commented Jun 22, 2018 •

edited

Loading

simonhong commented Jun 29, 2018 •

edited

Loading

simonhong commented Jul 2, 2018 •

edited

Loading

simonhong commented Jul 10, 2018 •

edited

Loading

simonhong commented Jul 13, 2018 •

edited

Loading