-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparkle: update server url and enable background update when browser stars #242
Conversation
…starts Request explicit update check when about page loads TODO: about page should show update status like windows version does.
brave_init_settings.gni
Outdated
brave_dsa_file = "dsa_pub.pem" | ||
} | ||
|
||
_base_update_url = "https://updates-test.bravesoftware.com/sparkle/Brave-Browser" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RyanJarv this url should be changed with real url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let's change the domain to updates.bravesoftware.com. (won't resolve now, but should be public in a bit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went ahead and updated that
Added the update url we'll be using. Looks good to me, will wait for another set of eyes on this as well though. |
brave_init_settings.gni
Outdated
brave_dsa_file = "dsa_pub.pem" | ||
} | ||
|
||
_base_update_url = "https://updates.bravesoftware.com/sparkle/Brave-Browser" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we put this in declare_args
so we can have test/staging urls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Request explicit update check when about page loads
TODO: about page should show update status like windows version does.
issue: brave/brave-browser#396
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: