Sparkle: update server url and enable background update when browser stars #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…starts Request explicit update check when about page loads TODO: about page should show update status like windows version does.
simonhong
commented
Jul 11, 2018
brave_init_settings.gni
Outdated
| brave_dsa_file = "dsa_pub.pem" | ||
| } | ||
|
|
||
| _base_update_url = "https://updates-test.bravesoftware.com/sparkle/Brave-Browser" |
There was a problem hiding this comment.
@RyanJarv this url should be changed with real url
There was a problem hiding this comment.
Yeah let's change the domain to updates.bravesoftware.com. (won't resolve now, but should be public in a bit)
There was a problem hiding this comment.
Went ahead and updated that
|
Added the update url we'll be using. Looks good to me, will wait for another set of eyes on this as well though. |
bridiver
reviewed
Jul 11, 2018
brave_init_settings.gni
Outdated
| brave_dsa_file = "dsa_pub.pem" | ||
| } | ||
|
|
||
| _base_update_url = "https://updates.bravesoftware.com/sparkle/Brave-Browser" |
There was a problem hiding this comment.
can we put this in declare_args so we can have test/staging urls?
bridiver
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request explicit update check when about page loads
TODO: about page should show update status like windows version does.
issue: brave/brave-browser#396
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: