Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Widevine ARM64 DLL fix #23415

Merged
merged 6 commits into from
May 7, 2024
Merged

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented May 3, 2024

Resolves brave/brave-browser#38012.

(Mostly) reverts the following PRs:

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please see #18695.

Upstream now offers the DLL from its public component update server.
@mherrmann mherrmann added the CI/run-windows-arm64 Run CI builds for Windows arm64 label May 3, 2024
@mherrmann mherrmann self-assigned this May 3, 2024
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label May 3, 2024
@mherrmann mherrmann marked this pull request as ready for review May 4, 2024 06:31
@mherrmann mherrmann requested review from simonhong, iefremov and a team as code owners May 4, 2024 06:31
@mherrmann mherrmann enabled auto-merge (squash) May 6, 2024 04:21
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mherrmann mherrmann merged commit fb192a5 into master May 7, 2024
19 checks passed
@mherrmann mherrmann deleted the remove-widevine-arm64-dll-fix branch May 7, 2024 01:02
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-windows-arm64 Run CI builds for Windows arm64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove our Workaround for Arm64 Widevine on Windows
3 participants