Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious crash on Arm64 Windows #22199

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

mherrmann
Copy link
Collaborator

Resolves brave/brave-browser#36014

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please test that Widevine still works on Arm64 Windows. For more concrete instructions, please see for instance the Test Plan at the bottom of #18695.

Please also check that component updates still work. For example, via the following steps:

  1. Delete the profile directory.
  2. Install a version of Brave with the fix in this PR.
  3. Start Brave.
  4. Immediately open brave://components/. You should see that the components are in the progress of being updated.
  5. Click "Check for update" for some components. It should perform an update check and should not show any errors.
  6. Leave brave://components open for 2-3 minutes. At some point, it should perform another update check of all components. Here too, no error should occur.

@mherrmann mherrmann added the CI/run-windows-arm64 Run CI builds for Windows arm64 label Feb 21, 2024
@mherrmann mherrmann self-assigned this Feb 21, 2024
@mherrmann mherrmann requested a review from a team as a code owner February 21, 2024 05:17
@mherrmann mherrmann merged commit 34e4e4f into master Feb 21, 2024
20 checks passed
@mherrmann mherrmann deleted the fix-crash-on-arm64-windows branch February 21, 2024 07:31
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 21, 2024
@mherrmann mherrmann mentioned this pull request May 3, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-windows-arm64 Run CI builds for Windows arm64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on Arm64 Windows
2 participants