-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on Arm64 Windows #22005
Merged
Merged
Fix build on Arm64 Windows #22005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is this something that's unit-testable? Might be good if we could have something that verifies writing/reading that pref, even if a follow-up.
Verification
Netflix -
|
Widevine prompt |
HD content |
---|---|
Amazon Prime - PASSED
Steps:
- installed
1.64.74
- launched Brave
- loaded
amazon.com
- clicked on
Prime Video
- logged in
- confirmed I was prompted to
Install and run Widevine
- clicked on
Allow
- clicked to play
Cars Life 3: The Royal Heist
Confirmed the content was streamed in High-Definition (HD) quality, "Best" quality level @ 1080p
(6.48 GB per hour)
Widevine prompt |
HD content |
---|---|
HBOMax - PASSED
Steps:
- installed
1.64.74
- launched Brave
- loaded
hbomax.com
- clicked on the
Sign In
button - clicked
Sign in to your account
- clicked
Sign in With a Provider
button - clicked on QA/avatar
- confirmed I was prompted to
Install and run Widevine
- clicked to play
Tom & Jerry
Confirmed the content was streamed in High-Definition (HD) quality, through visual inspection
Widevine prompt |
HD content |
---|---|
Bitmovin.com - PASSED
Steps:
- Installed 1.64.74
- launched Brave
- visit https://bitmovin.com/demos/drm in a new tab page
- confirmed I got prompted to Install and run Google Widevine
- clicked Allow
- played the video for protected DRM stream
- Confirmed the content was streamed in High-Definition (HD) quality (through visual inspection)
Widevine prompt |
HD content |
---|---|
mherrmann
pushed a commit
that referenced
this pull request
Feb 15, 2024
Uplift of #22005 (squashed) to release
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#35975.
One difference of this new implementation is that the persisted flag is now not stored in / as
but instead as
The previous value in
updateclientdata
does not need to be cleaned up because it was never set for any user. (Upstream has not yet made Arm64 Widevine available, so the condition never triggered.)Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Please test that Widevine still works on Arm64 Windows. For more concrete instructions, please see for instance the Test Plan at the bottom of #18695.