Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove our Workaround for Arm64 Widevine on Windows #38012

Closed
mherrmann opened this issue May 2, 2024 · 8 comments · Fixed by brave/brave-core#23415
Closed

Remove our Workaround for Arm64 Widevine on Windows #38012

mherrmann opened this issue May 2, 2024 · 8 comments · Fixed by brave/brave-core#23415
Assignees
@mherrmann
Labels
OS/Desktop OS/macOS OS/macOS-arm64 OS/Windows OS/Windows-arm64 QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.67.x - Release

Comments

@mherrmann
Copy link

Google did not use to offer native Widevine binaries for Arm64 Windows. We therefore implemented a workaround in #28318 that still makes Widevine work in Arm64 Brave. Now, it seems that Google does offer native Arm64 Widevine binaries on Windows. The goal of this issue is therefore to remove our workaround, to simplify our code base and make it more future-proof with regards to upstream changes.
@mherrmann mherrmann self-assigned this May 2, 2024
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 2, 2024
@mherrmann mherrmann mentioned this issue May 3, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 7, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 16, 2024 •
edited
Loading

As per the testplan, this issue needs to be verified on macOS so adding OS/macOS label.

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 16, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 16, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.67.85 Chromium: 125.0.6422.60 (Official Build) beta (arm64)
-- | --
Revision | d01060f5ec155e6eb64a335203663a29c0e5d81f
OS | Windows 11 Version 23H2 (Build 22631.3527)

Widevine component details - PASSED

Confirmed via brave://components that Widevine Content Decryption Module - Version: Version: 4.10.2710.0 was downloaded, in all cases

brave://components WidevineCdm folder
image image

Netflix - PASSED

Steps:

  1. installed 1.67.85
  2. launched Brave
  3. loaded netflix.com
  4. clicked on the Sign In link
  5. entered my credentials
  6. clicked on the Sign In button
  7. confirmed I got prompted to Install and run Widevine
  8. clicked Allow
  9. clicked on my user avatar
  10. played Life in color with David Attenborough (https://www.netflix.com/watch/81094026?trackId=255824129)

Confirmed the content was streamed in High-Definition (HD) quality (through visual inspection)

Widevine prompt HD content
image image

Amazon Prime - PASSED

Steps:

  1. installed 1.67.85
  2. launched Brave
  3. loaded amazon.com
  4. clicked on Prime Video
  5. logged in
  6. confirmed I was prompted to Install and run Widevine
  7. clicked on Allow
  8. clicked to play National Parks Exploration Series: Yellowstone
    (https://www.amazon.com/National-Parks-Exploration-Yellowstone-various/dp/B07B6BQYNN/ref=sr_1_2?s=instant-video&sr=1-2)

Confirmed the content was streamed in High-Definition (HD) quality, "Best" quality level @ 1080p (6.84 GB per hour)

Widevine prompt HD content
image 2024-05-16_11h05_50

HBOMax - PASSED

Steps:

  1. installed 1.67.85
  2. launched Brave
  3. loaded hbomax.com
  4. clicked on the Sign In button
  5. clicked Sign in to your account
  6. clicked Sign in With a Provider button
  7. finally signed in
  8. clicked on my username/avatar
  9. confirmed I was prompted to Install and run Widevine
  10. clicked on Alvin and the Chipmunks: The Squeakquel
    (https://play.max.com/video/watch/6690a829-eef6-4af0-93d9-1ce0c7d2cfed/9880f891-795b-4402-a434-bf28f69734a7)

Confirmed the content was streamed in High-Definition (HD) quality, through visual inspection

Widevine prompt HD content
image image

Bitmovin.com - PASSED

  1. Installed 1.67.85
  2. launched Brave
  3. visit https://bitmovin.com/demos/drm in a new tab page
  4. confirmed I got prompted to Install and run Widevine
  5. clicked Allow
  6. played the video for protected DRM stream
  7. opened brave://components
  8. confirmed Widevine Content Decryption Module is loaded
  9. confirmed widevinecdm_proxy.dll is loaded when Widevine is installed

Confirmed the content was streamed in High-Definition (HD) quality (through visual inspection)

step 4 step 6
image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 16, 2024
@LaurenWags
Copy link
Member

Removed QA Pass-Win64 so this gets a Win x64 check as well

@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to Completed in General May 28, 2024
@stephendonner
Copy link

stephendonner commented May 30, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.67.100 Chromium: 125.0.6422.112 (Official Build) beta (x86_64)
-- | --
Revision | 34fcbb6655521b55468af6c63601a8e3c5d24cd2
OS | macOS Version 14.5 (Build 23F79)

Widevine component details:

Confirmed via brave://components that Widevine Content Decryption Module - Version: 4.10.2710.0 was downloaded, in all cases

brave://components WidevineCdm folder
Screenshot 2024-05-30 at 10 28 58 AM Screenshot 2024-05-30 at 10 30 08 AM

Netflix - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded netflix.com
  4. clicked on the Sign In link
  5. entered my credentials
  6. clicked on the Sign In button
  7. confirmed I got prompted to Install and run Widevine
  8. clicked Allow
  9. clicked on my user avatar
  10. played Our Planet (https://www.netflix.com/watch/80094026)

Confirmed the content was streamed in High-Definition (HD) quality (through visual inspection)

Widevine prompt HD content
Screenshot 2024-05-30 at 10 36 36 AM Screenshot 2024-05-30 at 10 39 22 AM

Amazon Prime - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded amazon.com
  4. clicked on Prime Video
  5. logged in
  6. confirmed I was prompted to Install and run Widevine
  7. clicked on Allow
  8. clicked to play Ghostbusters: Frozen Empire - https://www.amazon.com/gp/video/detail/B0CXQ6TT96/ref=atv_hm_hom_c_lZOsi7_2_1?jic=8%7CEgNhbGw%3D

Confirmed the content was streamed in High-Definition (HD) quality, "Best" quality level @ 1080p (6.84 GB per hour)

Widevine prompt HD content
Screenshot 2024-05-30 at 10 45 18 AM Screenshot 2024-05-30 at 10 46 33 AM

HBOMax - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded hbomax.com
  4. clicked on the Sign In button
  5. clicked Sign in to your account
  6. clicked Sign in With a Provider button
  7. finally signed in
  8. clicked on my username/avatar
  9. confirmed I was prompted to Install and run Widevine
  10. clicked on Dune: Part Two (https://play.max.com/video/watch/914be9f6-e1b2-4f5f-aa34-de07a2a3423b/3c3df515-93b8-4410-b10a-414079529821)

Confirmed the content was streamed in High-Definition (HD) quality, through visual inspection

Widevine prompt HD content
Screenshot 2024-05-30 at 10 50 19 AM Screenshot 2024-05-30 at 10 50 53 AM

Bitmovin.com - PASSED

  1. installed 1.67.100
  2. launched Brave
  3. visited https://bitmovin.com/demos/drm in a new tab page
  4. confirmed I got prompted to Install and run Widevine
  5. clicked Allow
  6. played the video for protected DRM stream
  7. opened brave://components
  8. confirmed Widevine Content Decryption Module is loaded
step 4 step 6 step 8
Screenshot 2024-05-30 at 10 55 00 AM Screenshot 2024-05-30 at 10 56 25 AM Screenshot 2024-05-30 at 10 58 48 AM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS labels May 30, 2024
@stephendonner
Copy link

stephendonner commented May 30, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.67.100 Chromium: 125.0.6422.112 (Official Build) beta (arm64)
-- | --
Revision | 34fcbb6655521b55468af6c63601a8e3c5d24cd2
OS | macOS Version 13.6.4 (Build 22G513)

Widevine component details:

Confirmed via brave://components that ... was downloaded, in all cases

brave://components WidevineCdm folder
Screenshot 2024-05-30 at 11 19 24 AM Screenshot 2024-05-30 at 11 18 57 AM

Netflix - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded netflix.com
  4. clicked on the Sign In link
  5. entered my credentials
  6. clicked on the Sign In button
  7. confirmed I got prompted to Install and run Widevine
  8. clicked Allow
  9. clicked on my user avatar
  10. played Our Planet (https://www.netflix.com/watch/80094026)

Confirmed the content was streamed in High-Definition (HD) quality (through visual inspection)

Widevine prompt HD content
Screenshot 2024-05-30 at 11 24 53 AM Screenshot 2024-05-30 at 11 25 27 AM

Amazon Prime - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded amazon.com
  4. clicked on Prime Video
  5. logged in
  6. confirmed I was prompted to Install and run Widevine
  7. clicked on Allow
  8. clicked to play Ghostbusters: Frozen Empire - https://www.amazon.com/gp/video/detail/B0CXQ6TT96/ref=atv_hm_hom_c_lZOsi7_2_1?jic=8%7CEgNhbGw%3D

Confirmed the content was streamed in High-Definition (HD) quality, "Best" quality level @ 1080p (6.84 GB per hour)

Widevine prompt HD content
Screenshot 2024-05-30 at 11 34 22 AM Screenshot 2024-05-30 at 11 35 28 AM

HBOMax - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded hbomax.com
  4. clicked on the Sign In button
  5. clicked Sign in to your account
  6. clicked Sign in With a Provider button
  7. finally signed in
  8. clicked on my username/avatar
  9. confirmed I was prompted to Install and run Widevine
  10. clicked on Dune: Part Two (https://play.max.com/video/watch/914be9f6-e1b2-4f5f-aa34-de07a2a3423b/3c3df515-93b8-4410-b10a-414079529821)

Confirmed the content was streamed in High-Definition (HD) quality, through visual inspection

Widevine prompt HD content
Screenshot 2024-05-30 at 11 39 16 AM Screenshot 2024-05-30 at 11 40 03 AM

Bitmovin.com - PASSED

  1. installed 1.67.100
  2. launched Brave
  3. visited https://bitmovin.com/demos/drm in a new tab page
  4. confirmed I got prompted to Install and run Widevine
  5. clicked Allow
  6. played the video for protected DRM stream
  7. opened brave://components
  8. confirmed Widevine Content Decryption Module is loaded
step 4 step 6 step 8
Screenshot 2024-05-30 at 11 41 47 AM Screenshot 2024-05-30 at 11 42 15 AM Screenshot 2024-05-30 at 11 43 27 AM

@stephendonner stephendonner added QA Pass-macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 30, 2024
@stephendonner
Copy link

stephendonner commented May 30, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.67.100 Chromium: 125.0.6422.112 (Official Build) beta (64-bit)
-- | --
Revision | 34fcbb6655521b55468af6c63601a8e3c5d24cd2
OS | Windows 10 Version 22H2 (Build 19045.4474)

Widevine component details - PASSED

Confirmed via brave://components that Widevine Content Decryption Module - Version: Version: 4.10.2710.0 was downloaded, in all cases

brave://components WidevineCdm folder
image image

Netflix - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded netflix.com
  4. clicked on the Sign In link
  5. entered my credentials
  6. clicked on the Sign In button
  7. confirmed I got prompted to Install and run Widevine
  8. clicked Allow
  9. clicked on my user avatar
  10. played Life in color with David Attenborough (https://www.netflix.com/watch/81094026?trackId=255824129)

Confirmed the content was streamed in High-Definition (HD) quality (through visual inspection)

Widevine prompt HD content
image image

Amazon Prime - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded amazon.com
  4. clicked on Prime Video
  5. logged in
  6. confirmed I was prompted to Install and run Widevine
  7. clicked on Allow
  8. clicked to play Ghostbusters: Frozen Empire
    (https://www.amazon.com/gp/video/detail/B0CXQ6TT96/ref=atv_hm_hom_c_lZOsi7_2_1?jic=8%7CEgNhbGw%3D)

Confirmed the content was streamed in High-Definition (HD) quality, "Best" quality level @ 1080p (6.84 GB per hour)

Widevine prompt HD content
image image

HBOMax - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded hbomax.com
  4. clicked on the Sign In button
  5. clicked Sign in to your account
  6. clicked Sign in With a Provider button
  7. finally signed in
  8. clicked on my username/avatar
  9. confirmed I was prompted to Install and run Widevine
  10. clicked on Dune: Part Two
    (https://play.max.com/video/watch/914be9f6-e1b2-4f5f-aa34-de07a2a3423b/3c3df515-93b8-4410-b10a-414079529821)

Confirmed the content was streamed in High-Definition (HD) quality, through visual inspection

Widevine prompt HD content
image image

Bitmovin.com - PASSED

  1. Installed 1.67.100
  2. launched Brave
  3. visit https://bitmovin.com/demos/drm in a new tab page
  4. confirmed I got prompted to Install and run Widevine
  5. clicked Allow
  6. played the video for protected DRM stream
  7. opened brave://components
  8. confirmed Widevine Content Decryption Module is loaded

Confirmed the content was streamed in High-Definition (HD) quality (through visual inspection)

step 4 step 6 step 8
image image image

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 30, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.67.100 Chromium: 125.0.6422.112 (Official Build) beta (64-bit)
-- | --
Revision | 34fcbb6655521b55468af6c63601a8e3c5d24cd2
OS | Windows 11 Version 23H2 (Build 22631.3672)

Widevine component details - PASSED

Confirmed via brave://components that Widevine Content Decryption Module - Version: Version: 4.10.2710.0 was downloaded, in all cases

brave://components WidevineCdm folder
image image

Netflix - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded netflix.com
  4. clicked on the Sign In link
  5. entered my credentials
  6. clicked on the Sign In button
  7. confirmed I got prompted to Install and run Widevine
  8. clicked Allow
  9. clicked on my user avatar
  10. played Life in Color with David Attenborough (https://www.netflix.com/watch/81094026?trackId=255824129)

Confirmed the content was streamed in High-Definition (HD) quality (through visual inspection)

Widevine prompt HD content
image image

Amazon Prime - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded amazon.com
  4. clicked on Prime Video
  5. logged in
  6. confirmed I was prompted to Install and run Widevine
  7. clicked on Allow
  8. clicked to play National Parks Exploration Series: Yellowstone
    (https://www.amazon.com/National-Parks-Exploration-Yellowstone-various/dp/B07B6BQYNN/ref=sr_1_2?s=instant-video&sr=1-2)

Confirmed the content was streamed in High-Definition (HD) quality, "Best" quality level @ 1080p (6.84 GB per hour)

Widevine prompt HD content
image image

HBOMax - PASSED

Steps:

  1. installed 1.67.100
  2. launched Brave
  3. loaded hbomax.com
  4. clicked on the Sign In button
  5. clicked Sign in to your account
  6. clicked Sign in With a Provider button
  7. finally signed in
  8. clicked on my username/avatar
  9. confirmed I was prompted to Install and run Widevine
  10. clicked on Alvin and the Chipmunks: The Squeakquel
    (https://play.max.com/video/watch/6690a829-eef6-4af0-93d9-1ce0c7d2cfed/9880f891-795b-4402-a434-bf28f69734a7)

Confirmed the content was streamed in High-Definition (HD) quality, through visual inspection

Widevine prompt HD content
image image

Bitmovin.com - PASSED

  1. Installed 1.67.100
  2. launched Brave
  3. visit https://bitmovin.com/demos/drm in a new tab page
  4. confirmed I got prompted to Install and run Widevine
  5. clicked Allow
  6. played the video for protected DRM stream
  7. opened brave://components
  8. confirmed Widevine Content Decryption Module is loaded
  9. confirmed widevinecdm_proxy.dll is loaded when Widevine is installed

Confirmed the content was streamed in High-Definition (HD) quality (through visual inspection)

step 4 step 6
image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 30, 2024
@LaurenWags LaurenWags mentioned this issue Jun 11, 2024
Closed
@LaurenWags
Copy link
Member

Changed from release-notes/include to release-notes/exclude per discussion with @rebron 👍🏻

@rebron rebron removed this from General Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mherrmann mherrmann

Labels
OS/Desktop OS/macOS OS/macOS-arm64 OS/Windows OS/Windows-arm64 QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

Remove Widevine ARM64 DLL fix brave/brave-core
6 participants
@stephendonner @mherrmann @rebron @LaurenWags @brave-builds @MadhaviSeelam