Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Uplift-1.64.x - Leo QA Iteration 3 #22637

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Mar 16, 2024

  • Fixing AI-Chat bugs in the SDK where it does not save the user's model selection no matter what
  • Potentially fixing bugs in the SDK where the user is somehow premium but still rate-limited

Uplift of #22627
Resolves brave/brave-browser#36824
Resolves brave/brave-browser#36816
Resolves brave/brave-browser#36856
Resolves brave/brave-browser#36857

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

…nces and premium subscription credentials

Export Default-Model preference from Brave-Core to iOS
@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Mar 16, 2024
@Brandon-T Brandon-T added this to the 1.64.x - Release milestone Mar 16, 2024
@Brandon-T Brandon-T self-assigned this Mar 16, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner March 16, 2024 01:04
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.64.x approved 👍 QA has verified the PR on Nightly using 1.66.x as per #22627 (comment).

@kjozwiak kjozwiak merged commit f9f0974 into 1.64.x Mar 18, 2024
15 checks passed
@kjozwiak kjozwiak deleted the bugfix/QA-Iteration-3-1.64.x branch March 18, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants