Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading/purchasing Leo doesn't remove the Rate Limit Reached paywall #36824

Closed
kjozwiak opened this issue Mar 15, 2024 · 3 comments · Fixed by brave/brave-core#22627
Closed
Labels
browser-ai bug OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes release/blocking release-notes/exclude

Comments

@kjozwiak
Copy link
Member

Description:

Once the rate limit for either Mixtral or Claude Instant is reached, purchasing/upgrading Leo doesn't seem to be removing the rate limit. The account appears as PREMIUM and both Mixtral & Claude Instant appear as UNLIMITED, but the rate limit is not removed and keeps being displayed when attempting to use the premium models.

Steps to Reproduce

  1. install 1.63.176 Chromium: 122.0.6261.128 via TF
  2. once you've gone through onboarding/open Leo via the Hamburger Menu and run through the onboarding/T&S
  3. ensure that you have either Mixtral or Claude Instant selected (one of the premium models)
  4. run through either 5 questions or summarize a few pages (you should hit the Rate Limit reached modal within Leo)
  5. click on Upgrade via the Rate Limit modal and run through a purchase via TF
  6. once purchased, you'll notice that Leo becomes PREMIUM and both Mixtral & Claude appear as UNLIMITED
  7. attempt to summarize or ask Mixtral a question (or Claude depending on which rate limit you hit)

You'll notice that you'll get the Rate Limit reached modal even though you've premium.

Actual result:

RPReplay_Final1710476808.MP4

Expected result:

Once a user has upgraded/purchased Premium, the Rate Limit modal should be removed from both Mixtral & Claude

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the STR/Cases outlined above.

Brave Version:

1.63.176 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit)
--- | ---
Revision | 0767ff0f97fb...
OS | iOS 17.4 using iPhone 11
  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? N/A (1.63.x hasn't been released which includes Leo)

Device details:

  • iPhone 11 running iOS 17.4

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Mobile Safari? N/A

Additional Information

@kjozwiak
Copy link
Member Author

kjozwiak commented Mar 18, 2024

The above requires 1.63.178 or higher for 1.63.x verification 👍 @hffvld @Uni-verse as discussed via https://bravesoftware.slack.com/archives/C04KPE0BUDU/p1710518963710699, we'll basically need to create new accounts and run through the above to ensure that a Premium user is not getting rate limited. Lets pick three main cases that we can take and we'll cover those and ensure they're working. It's going to take too long to basically do the following:

  • create new accounts/with legit emails that Apple will accept
  • associate your device with the new email
  • get that email added into the TF program
  • run through the case only once and then repeat the above

@kjozwiak
Copy link
Member Author

kjozwiak commented Mar 18, 2024

Quick Note: As discussed with @Brandon-T & @evq, the above requires a brand new Apple ID/Account to run through the above so the following cases are using new accounts that have never subscribed to Leo before to ensure that they're not running/seeing the Rate Limit modal after becoming a Premium user.

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.63.178 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit)
---- | ---
Revision | 83e0e6978dea...
OS | iOS

Becoming Premium via the Rate Limit upgrade modal after hitting the 5 queries/hr rate limit - PASSED

RPReplay_Final1710796527.MP4

Running into Rate Limit on start-up then using new account to upgrade to Premium - PASSED

I didn't get a video of this case but basically went through the following which was failing before and always displayed the Rate Limit modal:

  • installed 1.63.178 Chromium: 122.0.6261.128 using an account that has recently purchased Premium via TF
  • once I hit the Rate Limit, I uninstalled Brave
  • quickly signed into a new Apple ID that has never bought Premium within the same ~hr so the Rate Limit isn't removed
  • attempted to Summarize a website and ran into the Rate Limit modal (assuming it's IP based)
  • using the new account, went through the purchase flow and upgraded to Premium

Once upgraded, ensured that I became a Premium user, both Mixtral & Claude became Unlimited and made sure that the Rate Limit paywall modal wasn't being displayed after ~5 queries were completed.

Upgrading to Premium on a brand new account before hitting Rate Limit - PASSED

RPReplay_Final1710818079.MP4

@kjozwiak
Copy link
Member Author

Removed QA/Test-All-Platforms as the functionality is basically the same between iPhone (mobile) and iPad. The only difference is the size/layout of the UI which is being checked while running through Leo via #36585 & #36596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai bug OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes release/blocking release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant