default modal for new conversations not respecting user choice and always reverting to Mixtral

[kjozwiak]

Description:

The default modal for new conversations setting under Advanced Settings doesn't seem to be working. If the user picks either Claude Instant or Llama 2 13b, it always seems to revert back to Mixtral.

Steps to Reproduce

1. install 1.63.176 Chromium: 122.0.6261.128 via TF
2. once you've gone through onboarding/open Leo via the Hamburger Menu and run through the onboarding/T&S
3. click on Hamburger Menu -> Settings -> Leo and tap on default modal for new conversations
4. pick either Claude Instant or Llama 2 13b and close the Settings page
5. either go back to the Leo settings page or take a look at Leo and notice that Mixtral is still the default model

Actual result:

RPReplay_Final1710477016.MP4

Expected result:

The default modal for new conversations setting should remember/respect the users choice rather than defaulting to Mixtral

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the STR/Cases outlined above.

Brave Version:

1.63.176 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit)
--- | ---
Revision | 0767ff0f97fb...
OS | iOS 17.4 using iPhone 11

• Can you reproduce this issue with the most recent build from TestFlight? Yes
• Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
• Can you reproduce this issue with the current build from AppStore? N/A (1.63.x hasn't been released which includes Leo)

Device details:

• iPhone 11 running iOS 17.4

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Is the issue reproducible on the latest version of Mobile Safari? N/A

Additional Information

[Brandon-T]

Brave-Core problem and also happens on Android and Desktop afaict.

We call api.changeModel("chat-claude-instant") or w/e the key is based on the selection for example.
It changes for sure.

Then when you create a new instance of Brave-Core API, it returns us chat-leo-expanded.
So this means Brave-Core does not persistently save the model selection.

I can probably fix it by saving it in a preference and forcing it every time, but that will require me to change the model every single time you load the screen which makes no sense.

This should be fix for Desktop and Android as well. It will likely be fixed for 1.64.x as it probably requires bigger changes.

[mattmcalister]

You sure this is a desktop problem, too? The setting persists for me. cc @stephendonner

[kjozwiak]

The above requires 1.63.178 or higher for 1.63.x verification 👍 @hffvld @Uni-verse keep in mind that #36886 is still an issue.

[hffvld]

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.4
- iPad Air / iPadOS 16.7.2
Brave build: 1.63 (178)
BraveCore: 1.63.178 (122.0.6261.128)

---

STEPS:

1. Follow the steps from default modal for new conversations not respecting user choice and always reverting to Mixtral #36816 (comment)
2. Verify

ACTUAL RESULTS:

• Verified that Brave can save Claude Instant or Llama 2 13b as a default language model. NOTE: This issue Default modal for new conversations reverting to Mixtral after restarting Brave - Follow up to #36816 #36886 still exists.

---

iPhone

2024-03-18_15-34-51.mp4

iPad

2024-03-18_15-39-04.mp4