Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update font's color for the Add Feedback when device is in Dark Mode #36857

Closed
hffvld opened this issue Mar 15, 2024 · 2 comments · Fixed by brave/brave-core#22627
Closed

Comments

@hffvld
Copy link
Contributor

hffvld commented Mar 15, 2024

Description:

We need to update the font's color for the Add Feedback when the device is in Dark Mode.

Steps to Reproduce

  1. Switch the device theme to the Dark Mode
  2. Launch Brave > Open Leo
  3. Send a query and wait for the answer
  4. Tap and hold on the response
  5. Dislike Answer > Observe

Actual result:

Hard to read Add Feedback when the device is in Dark Mode.

1 2
1 2

Expected result:

It must be easy to read Add Feedback when the device is in Dark Mode.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.63 (177)
BraveCore: 1.63.177 (122.0.6261.128)
  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? YES
  • Can you reproduce this issue with the current build from AppStore? N/A

Device details:

iPhone 14 / iOS 17.4

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

@kjozwiak
Copy link
Member

The above requires 1.63.178 or higher for 1.63.x verification 👍

@kjozwiak
Copy link
Member

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.63.178 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit) 
--- | ---
Revision | 83e0e6978dea...
OS | iOS

Using the STR/Cases outlined via #36857 (comment), ensured that Add Feedback was visible for Dislike via both Light & Dark themes as per the following:

Liked

Example Example
IMG_0147 IMG_0149

Disliked

Example Example
IMG_0148 IMG_0150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants