Expand CNAME uncloaking protection #14392
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#24278
Security review: https://github.com/brave/security/issues/961
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Apologies in advance for the massive test plan here, but it's a security-sensitive feature and we want to be extra sure that there is no DNS leakage before this can land in Release.
All of the following should be tested in Aggressive Shields blocking mode, and on as many OS platforms as possible. Note that many of these have already been QA tested in the past; the previous verification summaries can be used as a reference.
Android only: not all of the test plans here are applicable, but for those that are, be sure to enable the
#brave-adblock-cname-uncloaking
flag in brave://flags. It is currently disabled by Griffin under theDisableCnameUncloakingForAndroid
study.