-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only specify net::HostResolverSource::DNS when DoH is enabled #8279
Conversation
// which will be handled by system resolver | ||
|
||
SecureDnsConfig secure_dns_config = | ||
SystemNetworkContextManager::GetStubResolverConfigReader() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint nit: 4 spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
583e420
to
9422c13
Compare
9422c13
to
4537a79
Compare
audit deps failure is not related to this PR |
Verification PASSED on
|
Disabled |
Without filters |
Filters applied |
---|---|---|
DoH automatic
Automatic |
Without filters |
Filters applied |
---|---|---|
CloufFlare
Cloudflare |
Without filters |
Filters applied |
---|---|---|
OpenDNS
OpenDNS |
Without filters |
Filters applied |
---|---|---|
Resolves brave/brave-browser#14755
When DoH setting is automatic or off, it should be using system resolver other than forcing it to use async resolver
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
No DoH leak
brave://settings/security
dns filter
and start recordinghttps://tools.ietf.org/
tools.ietf.org
in wiresharkCNAME adblock
test bellowed scenarios with
DoH off
DoH automatic
DoH on
1
request being blockedbrave://adblock
2
requests blocked)