-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify resolver source breaks CNAME adblocking #14755
Comments
after brave/brave-core#8262 is landed and uplifted to release. |
labelling as |
Uplifted via brave/brave-core#8287 (review) & brave/brave-core#8288 (review). |
Verification
|
Disabled |
Without filters |
Filters applied |
---|---|---|
DoH automatic
Automatic |
Without filters |
Filters applied |
---|---|---|
Cloudflare
Cloudflare |
Without filters |
Filters applied |
---|---|---|
NextDNS
NextDNS |
Without filters |
Filters applied |
---|---|---|
Verification passed on
Brave | 1.23.68 Chromium: 90.0.4430.51 (Official Build) (64-bit)
-- | --
Revision | 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS | Windows 10 OS Version 2004 (Build 19041.867)
Verified the test plan from brave/brave-core#8279
No DoH leak
Ensured that there weren't any DNS
queries leaked when visiting https://tools.ietf.org
:
CNAME adblock
DoH disabled
Disabled |
Without filters |
Filters applied |
---|---|---|
DoH automatic
Automatic |
Without filters |
Filters applied |
---|---|---|
Cloudflare
Cloudflare |
Without filters |
Filters applied |
---|---|---|
NextDNS
NextDNS |
Without filters |
Filters applied |
---|---|---|
Verification passed on
Brave | 1.23.69 Chromium: 90.0.4430.61 (Official Build) (64-bit) |
---|---|
Revision | dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115} |
OS | Ubuntu 18.04 LTS |
Verified the test plan from brave/brave-core#8279
No DoH leak
Ensured that there weren't any DNS
queries leaked when visiting https://tools.ietf.org
:
CNAME adblock
DoH disabled
Disabled |
Without filters |
Filters applied |
---|---|---|
DoH automatic
Automatic |
Without filters |
Filters applied |
---|---|---|
Cloudflare
Cloudflare |
Without filters |
Filters applied |
---|---|---|
NextDNS
NextDNS |
Without filters |
Filters applied |
---|---|---|
Verification passed on OnePlus 6T with Android 10 running 1.22.66 x64 build
DoH AutomaticAndroid.ARM.DoH.Automatic.mp4DoH OpenDNSAndroid.ARM.DoH.Open.DNS.mp4DoH CloudFlareAndroid.ARM.DoH.Cloudflare.mp4Verification passed on Samsung Tab A with Android 10 running 1.22.66 x64 build
DoH AutomaticAndroid.Tab.DoH.Automatic.mp4DoH OpenDNSAndroid.Tab.DoH.OpenDNS.mp4DoH CloudFlareAndroid.Tab.DoH.CloudFlare.mp4 |
Moving to 1.23 after manually reverting from 1.22.x with brave/brave-core@f20e8ba The fix for this appears to be causing #14721 on all channels |
Caused by brave/brave-core#7731 for fixing DoH leak
And the resolver only checks local cache for CNAME request and we will only get
DNS_CACHE_MISS
error for empty cache on Linux reported by @antonok-edm but it did resolved for me on macos after clearing dns cacheThe text was updated successfully, but these errors were encountered: