Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify resolver source breaks CNAME adblocking #14755

Closed
darkdh opened this issue Mar 16, 2021 · 6 comments · Fixed by brave/brave-core#8279
Closed

Specify resolver source breaks CNAME adblocking #14755

darkdh opened this issue Mar 16, 2021 · 6 comments · Fixed by brave/brave-core#8279

Comments

@darkdh
Copy link
Member

darkdh commented Mar 16, 2021

Caused by brave/brave-core#7731 for fixing DoH leak
And the resolver only checks local cache for CNAME request and we will only get DNS_CACHE_MISS error for empty cache on Linux reported by @antonok-edm but it did resolved for me on macos after clearing dns cache

@darkdh
Copy link
Member Author

darkdh commented Mar 16, 2021

after brave/brave-core#8262 is landed and uplifted to release.
We should test on different platforms to figure out what still doesn't work
and disable CNAME adblocking when DoH is enabled on those platforms

@LaurenWags
Copy link
Member

labelling as QA/Blocked until this is uplifted

@kjozwiak
Copy link
Member

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 19, 2021
@stephendonner
Copy link

stephendonner commented Mar 19, 2021

Verification PASSED on macOS Big Sur using the following build:

Brave	1.22.65 Chromium: 89.0.4389.90 (Official Build) (x86_64)
Revision	62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS	macOS Version 11.2.3 (Build 20D91)

No DoH leak

Prerequisite: Followed https://wiki.wireshark.org/TLS and set up environment

Using the STR mentioned via brave/brave-core#8279 (comment), ensured that there weren't any DNS queries leaked when visiting https://tools.ietf.org:

Screen Shot 2021-03-19 at 8 32 40 AM

CNAME adblock

DoH disabled

Disabled Without filters Filters applied

DoH automatic

Automatic Without filters Filters applied
Screen Shot 2021-03-19 at 8 42 31 AM Screen Shot 2021-03-19 at 8 43 16 AM Screen Shot 2021-03-19 at 8 44 57 AM

Cloudflare

Cloudflare Without filters Filters applied
Screen Shot 2021-03-19 at 8 47 07 AM Screen Shot 2021-03-19 at 8 48 00 AM Screen Shot 2021-03-19 at 8 46 35 AM

NextDNS

NextDNS Without filters Filters applied
Screen Shot 2021-03-19 at 8 49 49 AM Screen Shot 2021-03-19 at 8 49 58 AM Screen Shot 2021-03-19 at 8 50 47 AM

Verification passed on

Brave | 1.23.68 Chromium: 90.0.4430.51 (Official Build) (64-bit)
-- | --
Revision | 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Verified the test plan from brave/brave-core#8279

No DoH leak

Ensured that there weren't any DNS queries leaked when visiting https://tools.ietf.org:
image

CNAME adblock

DoH disabled

Disabled Without filters Filters applied
image image image

DoH automatic

Automatic Without filters Filters applied
image image image

Cloudflare

Cloudflare Without filters Filters applied
image image image

NextDNS

NextDNS Without filters Filters applied
image image image

Verification passed on

Brave 1.23.69 Chromium: 90.0.4430.61 (Official Build) (64-bit)
Revision dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS Ubuntu 18.04 LTS

Verified the test plan from brave/brave-core#8279

No DoH leak

Ensured that there weren't any DNS queries leaked when visiting https://tools.ietf.org:
image

CNAME adblock

DoH disabled

Disabled Without filters Filters applied
image image image

DoH automatic

Automatic Without filters Filters applied
image image image

Cloudflare

Cloudflare Without filters Filters applied
image image image

NextDNS

NextDNS Without filters Filters applied
image image image

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 19, 2021
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.22.66 x64 build

DoH Automatic
Android.ARM.DoH.Automatic.mp4
DoH OpenDNS
Android.ARM.DoH.Open.DNS.mp4
DoH CloudFlare
Android.ARM.DoH.Cloudflare.mp4

Verification passed on Samsung Tab A with Android 10 running 1.22.66 x64 build

DoH Automatic
Android.Tab.DoH.Automatic.mp4
DoH OpenDNS
Android.Tab.DoH.OpenDNS.mp4
DoH CloudFlare
Android.Tab.DoH.CloudFlare.mp4

@bsclifton
Copy link
Member

Moving to 1.23 after manually reverting from 1.22.x with brave/brave-core@f20e8ba

The fix for this appears to be causing #14721 on all channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment