Disable CNAME uncloaking when DoH is enabled with an HTTPS proxy #11164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#15038
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
https_proxy
environment variable before starting the browser, e.g.export https_proxy=https://127.0.0.1:8080
(replace the IP and port as necessary). On Windows and macOS, visit brave://settings, search forproxy
, and selectOpen your computer's proxy settings
, then configure it there.Standard test
to completion. In my experience, this takes a very long time to complete using free public proxies, sometimes failing and requiring multiple refreshes. The test should complete with at least 1Servers found
.