-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DNSLink resolution #8068
Conversation
167ab4c
to
e3157da
Compare
to avoid an extra DNS request (at least for users who haven't yet opted into IPFS), i wonder if it's possible to look up this TXT record in the DNS cache instead? maybe https://source.chromium.org/chromium/chromium/src/+/master:net/dns/host_cache.h?q=dns%20cache&ss=chromium ? |
e3157da
to
1fc6b43
Compare
This cache should be used inside HostResolver, https://source.chromium.org/chromium/chromium/src/+/master:net/dns/host_resolver_manager.h;l=56?q=HostResolverManager&ss=chromium%2Fchromium%2Fsrc, Added flag to allow cache usage in parameters and changed code to use one resolver instance per tab helper, but in my tests with Wireshark I see DNS requests for same sites anyway. I will check this logic, probably would be better to create a separate issue for this |
0b1a194
to
c5640d7
Compare
7ff961f
to
1a3e6c0
Compare
204222b
to
93f6d9f
Compare
#include "chrome/browser/ui/browser_finder.h" | ||
#include "chrome/browser/ui/layout_constants.h" | ||
#include "chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h" | ||
#include "components/grit/brave_components_resources.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're missing some deps here, too. This target has check_includes = false
so you have to manually check unfortunately
368c74e
to
d004e22
Compare
f8e679f
to
96182d7
Compare
96182d7
to
de87165
Compare
13609: Added an Open in IPFS option for domains that have a TXT record that is prefixed with dnslink= 13611: Add a setting to automatically redirect for DNSLink
de87165
to
63dd112
Compare
Added an Open in IPFS option for domains that have a TXT record that is prefixed with dnslink=
Resolves brave/brave-browser#13609
Resolves brave/brave-browser#13611
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: