-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable CNAME uncloaking when a proxy extension with a socks fallback is enabled #10742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the Slack discussion, that looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need unit test for ProxySettingsAllowUncloaking
but since we need to get this out ASAP, it can be done as follow up
net::ProxyConfig::ProxyRules::Type::PROXY_LIST) { | ||
net::ProxyConfig::ProxyRules::Type::PROXY_LIST || | ||
(config.value().proxy_rules().type == | ||
net::ProxyConfig::ProxyRules::Type::PROXY_LIST_PER_SCHEME && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update the function comment, it describes only SingleProxy
aka PROXY_LIST
, not PROXY_LIST_PER_SCHEME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, updated the comment
agree that we need a follow-up with tests |
645a6d6
to
133af65
Compare
Resolves brave/brave-browser#19070
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
ssh 127.0.0.1 -D 8081
on Linux and probably macOS. You're welcome to run it on a different device, but the Proxy Servers setting above will need to be modified accordingly.Custom filters
section in brave://adblock:proxy
mode (should be the 3rd option).Run test
buttonallowed
(green).[System Proxy]
and run the test again. The request should beblocked
(red).[Direct]
and run the test again. The request should beblocked
(red).