Uplift 1.41.x Enable Solana dApps by default on desktop (BUNDLE)

[darkdh]

We need a bundle of PRs to make it works flawlessly when release.

Uplifted 11 PRs

Enable feature by default

1. Enable Solana dApps support by default on desktop #13825 (T)
   Resolves Enable Solana DApps support by default on desktop brave-browser#23520
2. Fix feature lint #13931
   Resolves feature.cc lint failure brave-browser#23641

Renderer crash fix

1. Attach JSSolanaProvider to a RenderFrame #13934 (T)
   Resolves Webview (tab) crash on att.com/internet/fiber in Solana support brave-browser#23645
2. Fix gin::Wrappable leak #13955 (T)
   Resolves Crash when loading/reloading Google Docs/Sheets (and other sites like Reddit) brave-browser#23681
3. Use WillReleaseScriptContext to destroy js wallet providers  #13962 (T)
   Resolves Js solana provider crash regression brave-browser#23700
4. Solana provider refactor #13977
   Resolves Solana provider refactoring brave-browser#23702
   (four attempts to fix potential double freeing)
5. Fix Solana dApps accountChanged crash #14018 (T)
   Resolves Tab webview crash when switching Solana Accounts brave-browser#23761

Wallet adapter compatibility

1. Allow optional parameters to be null/undefined in Solana dApps API #13939
   Resolves Solana dApps API compatibility in solana adapter  brave-browser#23653
2. Migrate window.solana to window.braveSolana #13965
   Resolves Expose window.braveSolana as the main provider brave-browser#23705
3. Fix solana dapp swap #14001 (T)
   Resolves Solana dApp compatibility bug when signing a swap transaction with Raydium brave-browser#23594

Audit fix

1. Bump solana/web3.js to v1.44.2 #13949
   Resolves Upgrade solana/web3.js brave-browser#23677

Test plan

Please use v1.42.41 or higher to test
PR that needs test has (T) at the end

[socket-security]

Socket Security Report

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package	Script field	Location
[email protected] (added)	binding.gyp	package.json via @solana/[email protected]
[email protected] (added)	install	package.json via @solana/[email protected]

🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Package	Location
[email protected] (added)	package.json via @solana/[email protected]

Socket.dev scan summary

Issue	Status
Did you mean?	✅ no new possible package typos
Install scripts	⚠️ 2 new install scripts detected
Telemetry	✅ no new telemetry
Troll package	✅ no new troll packages
Malware	✅ no new malware
Native code	⚠️ 1 new native module detected

Powered by socket.dev

[srirambv]

Verification passed on

Brave	1.42.42 Chromium: 103.0.5060.66 (Official Build) nightly (64-bit)
Revision	20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS	Windows 11 Version 21H2 (Build 22000.739)

Enable feature by default

#13825

Verified test plan from PR

Account Change	Sign Message	Connect-Lock	Connect-Disconnect	Transactions
13825-Account.Changed.mp4	13825-Sign.mp4	13825-Connect-Lock.mp4	13825-Connect-Disconnect.mp4	13825-Transactions.mp4

#13931

• Skipped as linked issue is marked as QA/No

Renderer crash fix

#13934

• Verified test plan from brave/brave-browser#23645
• Verified no crash when loading https://att.com/ and navigating to Internet which redirects to https://att.com/internet/
• Verified no crash when visiting page https://att.com/internet/fibre/
• Additional verification notes here

#13955

• Verified test plan from brave/brave-browser#23645
• Verified loading a GDoc (50 Mb file) and reloading multiple times doesn't crash the browser/webview
• Verified loading the file on both normal tabs and private tabs doesn't crash the browser/webview

#13962

• Verified test plan from brave/brave-browser#23681
• Verified loading a GDoc (50 Mb file) and reloading multiple times doesn't crash the browser/webview
• Verified loading the file on both normal tabs and private tabs doesn't crash the browser/webview

#13977

• Skipped as linked issue is marked as QA/No

Wallet adapter compatibility

#13939

• Skipped as linked issue is marked as QA/No

#13965

• Skipped as linked issue is marked as QA/No

Audit fix

#13949

• Skipped as linked issue is marked as QA/No

---

Encountered brave/brave-browser#23760 & brave/brave-browser#23761

[darkdh]

Added two new PRs that need test

1. Fix Solana dApps accountChanged crash #14018 (T)
2. Fix solana dapp swap #14001 (T)

[srirambv]

Verification passed on

Brave	1.42.48 Chromium: 103.0.5060.70 (Official Build) nightly (64-bit)
Revision	1543faf9f70e61c6f6e9c01ff20a2e3cf2ad55dc-refs/branch-heads/5060_53@{#4}
OS	Windows 11 Version 21H2 (Build 22000.739)

#14018

• Verified test plan from PR
• Verified no crash when switching between Solana Accounts

14108.mp4

#14001

• Verified test plan from PR
• Verified able to Swap SOL -> USDC on both https://radiyum.io/ and https://orca.so/

14001.mp4

[kjozwiak]

Uplift into 1.41.x approved 👍 QA has verified the PR on Nightly as per #14000 (comment) & #14000 (comment).