Solana provider refactoring #23702
Labels
dev-concern
feature/web3/wallet/dapps
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/No
release-notes/exclude
Milestone
Remove disconnect handler
We are currently doing it in
https://github.com/brave/brave-core/blob/b2cc506b7d573033e845c771976ba031343edb38/components/brave_wallet/renderer/js_ethereum_provider.cc#L128-L132
and https://github.com/brave/brave-core/blob/b2cc506b7d573033e845c771976ba031343edb38/components/brave_wallet/renderer/js_solana_provider.cc#L188-L192
It's not necessary to do that because mojo would reconnects automatically.
Separate JSSolanaProvider fromgin::Wrappable
we make
JSSolanaProvide
r a WeakPtr,pass that into the new wrappable class as the “delegate”
the new wrappable class just calls the existing methods on
JSSolanaProvider
after checking for null.ex.
Make JSSolanaProvider both
gin::Wrappable
andRederFrameObserver
Follow
DomAutomationController
and install it inBraveWalletRenderFrameObserver:: DidClearWindowObject
And then bindbrave_wallet::mojom::SolanaProvider
inRegisterAssociatedInterfaceBindersForRenderFrameHost
This deprecates Separate JSSolanaProvider from
gin::Wrappable
cc @bridiver
The text was updated successfully, but these errors were encountered: