Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature lint #13931

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Fix feature lint #13931

merged 1 commit into from
Jun 23, 2022

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jun 23, 2022

Resolves brave/brave-browser#23641

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@darkdh darkdh requested a review from a team as a code owner June 23, 2022 16:07
@darkdh darkdh self-assigned this Jun 23, 2022
@darkdh
Copy link
Member Author

darkdh commented Jun 23, 2022

lint in noplatform passed. skip the rest of the CI.

@darkdh darkdh merged commit 6d994f2 into master Jun 23, 2022
@darkdh darkdh deleted the feature-flag-lint branch June 23, 2022 18:02
@darkdh darkdh added this to the 1.42.x - Nightly milestone Jun 23, 2022
darkdh added a commit that referenced this pull request Jun 29, 2022
darkdh added a commit that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature.cc lint failure
2 participants