Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solana dApps API compatibility in solana adapter #23653

Closed
darkdh opened this issue Jun 23, 2022 · 0 comments · Fixed by brave/brave-core#13939
Closed

Solana dApps API compatibility in solana adapter #23653

darkdh opened this issue Jun 23, 2022 · 0 comments · Fixed by brave/brave-core#13939
Assignees
@darkdh
Labels
feature/web3/wallet/dapps feature/web3/wallet/solana OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.41.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Jun 23, 2022

We should also accept optional parameters as null or undefined, currently we reject it with INVALID_PARAMETERS error.
Ex. sendTransaction API in adapter
https://github.com/solana-labs/wallet-adapter/blob/244af02cb3dcf9334abf61cb9a11e497bde86d57/packages/core/base/src/adapter.ts#L33-L36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/web3/wallet/dapps feature/web3/wallet/solana OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Allow optional parameters to be null/undefined in Solana dApps API brave/brave-core
2 participants
@kjozwiak @darkdh