Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added placeholder to VPN plan expiration message #13621

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jun 6, 2022

Resolves brave/brave-browser#22914

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Live test

  1. Fresh profile
  2. Enable VPN / SKU / etc - set environment as staging
  3. Login to account.bravesoftware.com and sign in
  4. Check panel (click VPN button next to hamburger) to have VPN in the message
  5. Should have Looks like your most recent payment for Brave Firewall + VPN did not go through. (Brave Firewall + VPN is the part we care about)

Storybook test

  1. Launch latest storybook link
  2. Go to VPN > Panels > Error Subscription Expired
  3. Verify the string matches our expectations (ex: $1 is replaced)

@spylogsster spylogsster added this to the 1.41.x - Nightly milestone Jun 6, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jun 6, 2022
@spylogsster spylogsster changed the title Added placeholder Added placeholder to VPN plan expiration message Jun 6, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this live... but the code changes look good! I updated test plan and also storybook so that we can see the replacement happening in Storybook (in the component). That works great!

@bsclifton
Copy link
Member

OK found a way to test the expired text live and verified it looks great! Will update test plan
image

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Placeholder is missing in a string
3 participants