Merge pull request #13621 from brave/brvae-22914

Added placeholder to VPN plan expiration message
brave · Jun 9, 2022 · 8e3a9a3 · 8e3a9a3
2 parents 2a55f5e + 40729f1
commit 8e3a9a3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/components/brave_vpn/resources/panel/components/error-subscription-failed-panel/index.tsx b/components/brave_vpn/resources/panel/components/error-subscription-failed-panel/index.tsx
@@ -33,7 +33,7 @@ function ErrorSubscriptionFailed () {
           {getLocale('braveVpnPaymentFailure')}
         </S.ReasonTitle>
         <S.ReasonDesc>
-          {getLocale('braveVpnPaymentFailureReason')}
+          {getLocale('braveVpnPaymentFailureReason').replace('$1', getLocale('braveVpn'))}
         </S.ReasonDesc>
         <S.ActionArea>
           <Button

diff --git a/components/brave_vpn/resources/panel/stories/locale.ts b/components/brave_vpn/resources/panel/stories/locale.ts
@@ -30,7 +30,7 @@ provideStrings({
   braveVpnPurchaseFailed: 'Unable to check the status of your purchase, probably a network problem, try again or contact support.',
   braveVpnEditPaymentMethod: 'Edit payment method',
   braveVpnPaymentFailure: 'There was a problem with your payment',
-  braveVpnPaymentFailureReason: 'Looks like your most recent payment for did not go through. Access to this subscription will pause until the payment issue is resolved. Try to edit your payment method, or contact Brave support.',
+  braveVpnPaymentFailureReason: 'Looks like your most recent payment for $1 did not go through. Access to this subscription will pause until the payment issue is resolved. Try to edit your payment method, or contact Brave support.',
   braveVpnSupportEmail: 'Your email address',
   braveVpnSupportSubject: 'Subject',
   braveVpnSupportSubjectNotSet: 'Please choose a reason',

diff --git a/components/resources/brave_vpn_strings.grdp b/components/resources/brave_vpn_strings.grdp
@@ -117,7 +117,7 @@
   </message>
 
   <message name="IDS_BRAVE_VPN_PAYMENT_FAILURE_REASON" desc="A long form on the consequence of failed payment">
-    Looks like your most recent payment for did not go through. Access to this subscription will pause until the payment issue is resolved. Try to edit your payment method, or contact Brave support.
+    Looks like your most recent payment for <ph name="VALUE">$1<ex>VPN Subscription</ex></ph> did not go through. Access to this subscription will pause until the payment issue is resolved. Try to edit your payment method, or contact Brave support.
   </message>
 
   <message name="IDS_BRAVE_VPN_SUPPORT_EMAIL" desc="Label above email input on VPN support">