Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added placeholder to VPN plan expiration message #13621

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Added placeholder to VPN plan expiration message #13621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a8216a
Added placeholder
spylogsster Jun 6, 2022
40729f1
Updated storybook to have the new string (incl placeholder)
bsclifton Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/brave_vpn/resources/panel/components/error-subscription-failed-panel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function ErrorSubscriptionFailed () {
{getLocale('braveVpnPaymentFailure')}
</S.ReasonTitle>
<S.ReasonDesc>
{getLocale('braveVpnPaymentFailureReason')}
{getLocale('braveVpnPaymentFailureReason').replace('$1', getLocale('braveVpn'))}
</S.ReasonDesc>
<S.ActionArea>
<Button
Expand Down
2 changes: 1 addition & 1 deletion components/brave_vpn/resources/panel/stories/locale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ provideStrings({
braveVpnPurchaseFailed: 'Unable to check the status of your purchase, probably a network problem, try again or contact support.',
braveVpnEditPaymentMethod: 'Edit payment method',
braveVpnPaymentFailure: 'There was a problem with your payment',
braveVpnPaymentFailureReason: 'Looks like your most recent payment for did not go through. Access to this subscription will pause until the payment issue is resolved. Try to edit your payment method, or contact Brave support.',
braveVpnPaymentFailureReason: 'Looks like your most recent payment for $1 did not go through. Access to this subscription will pause until the payment issue is resolved. Try to edit your payment method, or contact Brave support.',
braveVpnSupportEmail: 'Your email address',
braveVpnSupportSubject: 'Subject',
braveVpnSupportSubjectNotSet: 'Please choose a reason',
Expand Down
2 changes: 1 addition & 1 deletion components/resources/brave_vpn_strings.grdp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
</message>

<message name="IDS_BRAVE_VPN_PAYMENT_FAILURE_REASON" desc="A long form on the consequence of failed payment">
Looks like your most recent payment for did not go through. Access to this subscription will pause until the payment issue is resolved. Try to edit your payment method, or contact Brave support.
Looks like your most recent payment for <ph name="VALUE">$1<ex>VPN Subscription</ex></ph> did not go through. Access to this subscription will pause until the payment issue is resolved. Try to edit your payment method, or contact Brave support.
</message>

<message name="IDS_BRAVE_VPN_SUPPORT_EMAIL" desc="Label above email input on VPN support">
Expand Down