Edit payment method error-dialog text is wrong

[stephendonner]

Description

Edit payment method error-dialog text is wrong

Steps to Reproduce

1. install 1.39.92
2. launch Brave
3. follow https://bravesoftware.slack.com/archives/CC5SA8CCB/p1651597201141019?thread_ts=1651597077.189229&cid=CC5SA8CCB to create a VPN account on development but without finishing purchase flow through Stripe
4. click on the VPN button on the toolbar
5. read the dialog

Actual result:

Looks like your most recent payment for did not go through.

Expected result:

Not 100% sure here the final copy

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.39.92 Chromium: 101.0.4951.54 (Official Build) beta (x86_64)
Revision	67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS	macOS Version 12.4 (Build 21F5071b)

cc @nullhook @rmcfadden3 @rebron @mattmcalister

[rmcfadden3]

Looks like maybe there was supposed to be a param that auto-inserted the Premium product name between "for" and "did" here. Not sure. But anyways the easy fix would just be to remove the "for" so it reads "Looks like your most recent payment did not go through."

CC @mattmcalister to sanity check on that.

[spylogsster]

fixed in brave/brave-core#13621, added placeholder

[stephendonner]

Verified PASSED using

Brave	1.42.13 Chromium: 103.0.5060.53 (Official Build) nightly (x86_64)
Revision	a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS	macOS Version 12.5 (Build 21G5046c)

Confirmed Brave Firewall + VPN appears in the Edit payment method error-message dialog.

light	dark