-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay incrementing shields counter until first render #888
Labels
design
A design change, especially one which needs input from the design team
feature/shields
The overall Shields feature in Brave.
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release/not-blocking
release-notes/exclude
Milestone
Comments
srirambv
added
bug
feature/shields
The overall Shields feature in Brave.
release/not-blocking
labels
Aug 30, 2018
Reproduced on macOS with |
tildelowengrimm
added
design
A design change, especially one which needs input from the design team
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
and removed
bug
labels
Oct 31, 2018
tildelowengrimm
changed the title
Shields starts showing blocked count even before page is loaded in webview
Delay incrementing shields counter until first render
Nov 7, 2018
Updated title. Cezar, if this isn't implementable with the APIs you currently have access to, I'll move it to the backend pile. |
tildelowengrimm
added
priority/P4
Planned work. We expect to get to it "soon".
and removed
priority/P5
Not scheduled. Don't anticipate work on this any time soon.
labels
Nov 28, 2018
cezaraugusto
added a commit
to brave/brave-core
that referenced
this issue
May 27, 2019
only update resources blocked after shields is active for the site fix brave/brave-browser#888
This was referenced Aug 2, 2019
This was referenced Dec 10, 2019
This was referenced Dec 10, 2019
This was referenced Dec 10, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
A design change, especially one which needs input from the design team
feature/shields
The overall Shields feature in Brave.
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release/not-blocking
release-notes/exclude
Test Case
Original Issue
Description
Shields starts showing blocked count even before page is loaded in webview
Steps to Reproduce
Actual result:
Expected result:
Should only show badge when icon is active and not on inactive icon
Reproduces how often:
100%
Brave version (about:brave info)
Reproducible on current release:
No
Website problems only:
Additional Information
cc: @brave/legacy_qa @bbondy @petemill
The text was updated successfully, but these errors were encountered: