Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay incrementing shields counter until first render #888

Closed
srirambv opened this issue Aug 30, 2018 · 3 comments · Fixed by brave/brave-core#2507
Closed

Delay incrementing shields counter until first render #888

srirambv opened this issue Aug 30, 2018 · 3 comments · Fixed by brave/brave-core#2507
Assignees
Labels
design A design change, especially one which needs input from the design team feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/not-blocking release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 30, 2018

Test Case

Original Issue

Description

Shields starts showing blocked count even before page is loaded in webview

Steps to Reproduce

  1. Upgrade to 0.54.3
  2. Open a new tab and load a site
  3. Before the page is loaded in webview, shields starts showing blocked count in badge even on disabled icon before changing to active icon (see recording below)

Actual result:

blockcount

Expected result:

Should only show badge when icon is active and not on inactive icon

Reproduces how often:

100%

Brave version (about:brave info)

Brave 0.54.3 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)
Revision 1911f781145b803e04f2d0b5b1a0146ae69fcbdc-refs/branch-heads/3528@{#9}
OS Windows

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @brave/legacy_qa @bbondy @petemill

@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. release/not-blocking labels Aug 30, 2018
@srirambv srirambv added this to the Backlog milestone Aug 30, 2018
@LaurenWags
Copy link
Member

Reproduced on macOS with 0.55.3

@tildelowengrimm tildelowengrimm added design A design change, especially one which needs input from the design team priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed bug labels Oct 31, 2018
@tildelowengrimm tildelowengrimm changed the title Shields starts showing blocked count even before page is loaded in webview Delay incrementing shields counter until first render Nov 7, 2018
@tildelowengrimm
Copy link
Contributor

Updated title. Cezar, if this isn't implementable with the APIs you currently have access to, I'll move it to the backend pile.

@tildelowengrimm tildelowengrimm added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 28, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue May 27, 2019
only update resources blocked after shields is active for the site
fix brave/brave-browser#888
@kjozwiak kjozwiak added this to the 0.68.x - Nightly milestone May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/not-blocking release-notes/exclude
Projects
None yet
8 participants