Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation for Rewards widget #6760

Closed
GeetaSarvadnya opened this issue Nov 4, 2019 · 3 comments
Closed

Missing translation for Rewards widget #6760

GeetaSarvadnya opened this issue Nov 4, 2019 · 3 comments
Labels
l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 4, 2019

Description

Missing translation for Rewards widget

Steps to Reproduce

  1. Set device locale to Germany/France/Australia/Japan
  2. Clean profile 0.71.111
  3. Enable rewards
  4. Open a NTP

Actual result:

Missing translation for Rewards widget

image

image

Expected result:

Rewards widget should be translated

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.71.111 Chromium: 78.0.3904.87 (Offizieller Build) (64-Bit)
Überarbeitung 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
Betriebssystem Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @ryanml @rebron @NejcZdovc @mandar-brave

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya this is expected as we didn't order new translations yet

@NejcZdovc NejcZdovc removed the bug label Nov 5, 2019
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 19, 2019
@rebron
Copy link
Collaborator

rebron commented Dec 10, 2019

@GeetaSarvadnya Is this looking ok now with 1.1?

@LaurenWags
Copy link
Member

Looks good with 1.1.20:

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS macOS Version 10.13.6 (Build 17G5019)

German:
Rewards NTP Widget - German

French:
French

Australian English:
English-Australian

Japanese:
Japanese

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants