-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hovering over a bookmark bar item shows corners as rounded #7210
Comments
@bsclifton noticed that the separator isn't always shown and that drag/drop of bookmarks into folders is difficult. When checking this issue we should retest this part as well. |
Fixes brave/brave-browser#7210 Used chromium_src override to use the default highlight path for the buttons instead of installing the pill hightlight path.
Reproduced in Windows 10 x64 - 1.1.18 |
Adding 1.1.x milestone as this is likely a C79 regression we want resolved before releasing. |
@bsclifton @rebron are we planning on getting this into the next release? It looks like brave/brave-core#4135 has been completed/reviewed. We should get this merged into |
Waiting on code review from @bridiver brave/brave-core#4135 |
Verified passed with
Verification passed on
|
Brave | 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit) |
---|---|
Revision | 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888} |
OS | Windows 10 OS Version 1803 (Build 17134.228) |
Description
On C79 builds when you hover over a bookmark bar item the highlighted item is rounded instead of more square. C78 builds show the hover correctly.
Steps to Reproduce
Actual result:
See that highlighted item corners are rounded:
Expected result:
Corners should be more square
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @bsclifton @rebron @brave/legacy_qa
The text was updated successfully, but these errors were encountered: