Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hovering over a bookmark bar item shows corners as rounded #7210

Closed
LaurenWags opened this issue Dec 4, 2019 · 7 comments · Fixed by brave/brave-core#4135
Closed

hovering over a bookmark bar item shows corners as rounded #7210

LaurenWags opened this issue Dec 4, 2019 · 7 comments · Fixed by brave/brave-core#4135

Comments

@LaurenWags
Copy link
Member

Description

On C79 builds when you hover over a bookmark bar item the highlighted item is rounded instead of more square. C78 builds show the hover correctly.

Steps to Reproduce

  1. Add bookmark/folder to bookmarks bar.
  2. Hover over item.

Actual result:

See that highlighted item corners are rounded:
Screen Shot 2019-12-04 at 3 20 01 PM

Expected result:

Corners should be more square
Screen Shot 2019-12-04 at 3 18 56 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 1.4.3 Chromium: 79.0.3945.56 (Official Build) nightly (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? not with 1.0.1
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? yes with 1.4.3

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @bsclifton @rebron @brave/legacy_qa

@LaurenWags
Copy link
Member Author

Does not reproduce on 1.1.17 (last C78 1.1.x build):
Screen Shot 2019-12-04 at 3 22 03 PM

@LaurenWags
Copy link
Member Author

@bsclifton noticed that the separator isn't always shown and that drag/drop of bookmarks into folders is difficult. When checking this issue we should retest this part as well.

@mkarolin mkarolin self-assigned this Dec 4, 2019
mkarolin added a commit to brave/brave-core that referenced this issue Dec 4, 2019
Fixes brave/brave-browser#7210

Used chromium_src override to use the default highlight path for the
buttons instead of installing the pill hightlight path.
@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.1.18

@LaurenWags
Copy link
Member Author

Adding 1.1.x milestone as this is likely a C79 regression we want resolved before releasing.

@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2019

@bsclifton @rebron are we planning on getting this into the next release? It looks like brave/brave-core#4135 has been completed/reviewed. We should get this merged into Nightly/QA'd and get the uplift PR's going if this is something we want out in 1.1.x.

@bsclifton
Copy link
Member

Waiting on code review from @bridiver brave/brave-core#4135

@LaurenWags
Copy link
Member Author

LaurenWags commented Dec 10, 2019

Verified passed with

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Screen Shot 2019-12-10 at 8 57 14 AM

Screen Shot 2019-12-10 at 8 57 22 AM

* Verified able to drag and drop items on bookmark bar without issue.

Verification passed on

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS Ubuntu 18.04 LTS

image
image
image

Verification passed on

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS Windows 10 OS Version 1803 (Build 17134.228)

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment