-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab Bar shadows #788
Labels
closed/stale
Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
design
A design change, especially one which needs input from the design team
Comments
petemill
added
the
design
A design change, especially one which needs input from the design team
label
Aug 20, 2018
14 tasks
petemill
added a commit
to brave/brave-core
that referenced
this issue
Sep 27, 2018
Adds tab painting function for shadows. In order to paint the tab's (top) shadow above the tab's (previous) bounds rectangle, we must extend the tab (and tabstrip) higher, to the top of the window (usually 8px of space). This is because the Views framework does not allow painting outside a View's bounds. A hacky alternative would be to pass the PaintInfo from the BrowserView through the TabStrip child to the Tab descendants, so that a canvas can be created that can span the larger window rectangle. Aside from that strategy not done anywhere else in Chromium, it could cause issues if the tabs end up on a different paint layer, as well as paint invalidation and caching issues that would need to be solved. Close brave/brave-browser#788
rebron
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Jan 8, 2019
This was referenced Dec 3, 2019
This was referenced Dec 3, 2019
rebron
added
priority/P4
Planned work. We expect to get to it "soon".
and removed
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Feb 5, 2020
@rebron Should we close this as won't fix for now? |
This was referenced Feb 24, 2022
This was referenced Feb 25, 2022
This was referenced Feb 25, 2022
This was referenced Feb 25, 2022
This was referenced Feb 26, 2022
Closing as stale. |
rebron
added
the
closed/stale
Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
label
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed/stale
Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
design
A design change, especially one which needs input from the design team
Tab Bar inset / Active Tab outset shadows
The text was updated successfully, but these errors were encountered: