Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect bitfield value is displayed for daily and monthly usage pings #21336

Closed
GeetaSarvadnya opened this issue Feb 25, 2022 · 1 comment
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 25, 2022

Description

Incorrect bitfield value is displayed for daily and monthly usage pings

Steps to Reproduce

  1. Clean profile, launch 1.38.1 nightly build
  2. Daily/weekly/monthly usage pings are True which is correct as browser usage pings are sent after browser launch
  3. Verified wallet state is 0 as expected
    image
  4. Close the browser
  5. Set the system date 4 days ahead (I have set it to 1st March 2022)
  6. Relaunch the browser and unlock the wallet
  7. Daily/weekly/monthly usage pings are as below
    image
  8. Daily and monthly usage ping is true which looks correct logically as on 1st march new month starts and usage ping for last month is shown as true as expected, But weekly usage pings are 0 which is as NOT expected as the wallet is created on 25th Feb, hence I would expect weekly usage should also be true
  9. The wallet bitfield value is 3 (daily, weekly, monthly) instead of 5 (daily, monthly)

Note: Here there are two issues, 1. I am expecting weekly usage ping to true as I feel wallet is used in the previous week
2. If I am wrong and weekly usage ping should be false then wallet bitfield value should be 5 (daily, monthly) instead of 3 (daily, weekly, monthly)

Actual result:

Incorrect bitfield value is displayed for daily and monthly usage pings

Expected result:

The usage flag for weekly should be true as the wallet is used in the previous week

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.38.1 Chromium: 99.0.4844.45 (Official Build) nightly (64-bit)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS Windows 10 Version 21H2 (Build 19044.1526)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@GeetaSarvadnya GeetaSarvadnya changed the title Incorrect bitfield value is displayed for daily and nightly usage pings Incorrect bitfield value is displayed for daily and monthly usage pings Feb 25, 2022
@GeetaSarvadnya
Copy link
Author

The issue is invalid as per my discussion with @DJAndries This works as expected and wallet usage values are totally independent from the browser usage flags (the monthly, weekly, and daily URL parameters). Hence closing the issue as invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant