Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch verified pubs are Not being added to a-c table #6142

Open
GeetaSarvadnya opened this issue Sep 24, 2019 · 10 comments
Open

Twitch verified pubs are Not being added to a-c table #6142

GeetaSarvadnya opened this issue Sep 24, 2019 · 10 comments
Assignees

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 24, 2019

Description

Twitch verified pubs are Not being added to a-c table

Steps to Reproduce

  1. Brave 0.69.128
  2. Visit verified twitch pubs (https://www.twitch.tv/jennrhim/videos)
  3. Watch any video and spend min time
  4. Visit verified twitter pub (https://twitter.com/kamiljozwiak)
  5. Twitter and twitch pubs are not added to a-c table

Actual result:

Twitter and Twitch verified pubs are being added to a-c table
image

Expected result:

Verified pubs should be added to a-c table

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not in 0.68.129 and 0.68.131
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc

@GeetaSarvadnya
Copy link
Author

The same issue for Reddit pubs as well in the panel pubs name is displayed but pubs is not getting added to a-c table, the only domain name is added

image
image

@NejcZdovc
Copy link
Contributor

we don't have yet support for AC for Twitter

@NejcZdovc
Copy link
Contributor

we don't have support for reddit AC

@bsclifton
Copy link
Member

bsclifton commented Sep 24, 2019

@GeetaSarvadnya is this supposed to be: Twitter and Twitch verified pubs are *NOT* being added to a-c table?
(ex: is this a regression? or a feature request?)

@GeetaSarvadnya GeetaSarvadnya changed the title Twitter and Twitch verified pubs are being added to a-c table Twitter and Twitch verified pubs are Not being added to a-c table Sep 25, 2019
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Sep 25, 2019

@bsclifton Yup, you're right it should be Twitter and Twitch verified pubs are *NOT* being added to a-c table? - I have updated the description. Looks like its regression for Twitch, 0.68.131 Chromium: 76.0.3809.100 onwards this stopped working.

  • 0.68.140 Chromium: 77.0.3865.90 - Twitch verified pubs are NOT being added to a-c table
  • 0.68.139 Chromium: 77.0.3865.90 - Twitch verified pubs are NOT being added to a-c table
  • 0.68.138 Chromium: 77.0.3865.75 - Twitch verified pubs are NOT being added to a-c table
  • 0.68.132 Chromium: 76.0.3809.132- Twitch verified pubs are NOT being added to a-c table
  • 0.68.131 Chromium: 76.0.3809.100 -Twitch verified pubs are being added to a-c table
  • 0.68.129 Chromium: 76.0.3809.100 - Twitch verified pubs are being added to a-c table

image

@GeetaSarvadnya GeetaSarvadnya changed the title Twitter and Twitch verified pubs are Not being added to a-c table Twitch verified pubs are Not being added to a-c table Sep 25, 2019
@LaurenWags
Copy link
Member

I've noticed this happens sometimes, but not others for me. Sometimes twitch publishers are added immediately and other times it can take up to 5 minutes. This wasn't always the case though, so something seems like it's wrong. I believe @kjozwiak has encountered this as well.

@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 18, 2019
@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 5, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jun 16, 2020

Still encountering this with

Brave 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS macOS Version 10.14.6 (Build 18G3020)

cc @NejcZdovc

@LaurenWags
Copy link
Member

Noticed with 1.19.x that after a browser restart twitch publishers are more reliably being added to AC, but without the restart they are not added.

Brave | 1.19.75 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | macOS Version 10.15.7 (Build 19H15)

@GeetaSarvadnya
Copy link
Author

Seeing the same issue in Windows 10 x64 - Twitch pubs are added to AC table only after browser restart


Brave | 1.19.75 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

image

@LaurenWags
Copy link
Member

Logged #13391 for restart as noted in #6142 (comment) and #6142 (comment)

@Miyayes Miyayes added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants