Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude toggle crash #5457

Closed
NejcZdovc opened this issue Jul 30, 2019 · 1 comment · Fixed by brave/brave-core#3044
Closed

Exclude toggle crash #5457

NejcZdovc opened this issue Jul 30, 2019 · 1 comment · Fixed by brave/brave-core#3044

Comments

@NejcZdovc
Copy link
Contributor

Description

Steps to Reproduce

  1. Enable rewards
  2. Go to a site
  3. Open panel
  4. toggle auto include

Actual result:

You can't exclude site

Expected result:

You can exclude site

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 24, 2019

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

(Verified excluding and including Twitter/YT/Twitch/Sites/Vimeo/Reddit pubs)

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment