Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes exclude crash #3044

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fixes exclude crash #3044

merged 1 commit into from
Jul 31, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 30, 2019

Resolves brave/brave-browser#5457

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to a site
  • open panel
  • toggle auto include
  • make sure that you can exclude and include it multiple times

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.70.x - Nightly milestone Jul 30, 2019
@NejcZdovc NejcZdovc requested a review from kylehickinson July 30, 2019 19:19
@NejcZdovc NejcZdovc self-assigned this Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude toggle crash
2 participants