Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart required to get media publishers added to AC #13391

Open
LaurenWags opened this issue Jan 6, 2021 · 3 comments
Open

Restart required to get media publishers added to AC #13391

LaurenWags opened this issue Jan 6, 2021 · 3 comments
Assignees
Labels

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 6, 2021

Description

Found while testing #12107

Media publishers aren't immediately added to auto contribute list after Rewards is enabled, need to restart the browser. Need to use Greaselion component version 1.0.40.

Also noted here: #6142 (comment) and #6142 (comment)

Steps to Reproduce

  1. Clean profile 1.19.x (launched with /Applications/Brave\ Browser\ Dev.app/Contents/MacOS/Brave\ Browser\ Dev --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --use-dev-goupdater-url
  2. Click on BAT logo and select "Start using Brave Rewards"
  3. Watch logs, once publisher prefix list is downloaded, open a new tab and visit a media pub (ex. twitter.com/bravesampson)
  4. Wait on page for at least 10s
  5. Open a new tab and navigate to brave://rewards
  6. Twitter is added to AC list, but not "Sampson on Twitter" as expected.
  7. Restart browser.
  8. Visit another twitter publisher (ex twitter.com/brave)
  9. Wait on page for 10s
  10. Open a new tab and navigate to brave://rewards
  11. Now media pub is added to AC list

Reproduced using Twitter, Reddit, Twitch, Vimeo (clean profile for each publisher type)

Actual result:

Media publisher not added to AC list without restart

Expected result:

No restart needed, media publisher should be added to AC list after enabling Rewards

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS macOS Version 10.15.7 (Build 19H15)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a (not available in 1.18.x)
  • Can you reproduce this issue with the beta channel? yes 1.19.x
  • Can you reproduce this issue with the nightly channel? yes 1.20.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @emerick @kjozwiak @marshall @rebron

@LaurenWags
Copy link
Member Author

Seems as though 2 restarts are required when attempting to get Vimeo publishers added to AC list on Linux.

Brave	1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	Linux

@kjozwiak
Copy link
Member

kjozwiak commented Jan 6, 2021

Definitely a challenge to get Vimeo added into the a-c list on Win 10 x64. @emerick I shared the logs via Slack but here's basically the STR/Case:

  • launch 1.19.76 CR: 87.0.4280.101 using --use-dev-goupdater-url and ensure that Brave Local Data Updater - Version: 1.0.40 is being downloaded via brave://components
  • click on the rewards panel and click on Start using Brave Rewards|
  • restart the browser (make sure you're using the same environment flags as before)
  • visit https://vimeo.com/pakocampo and wait ~1min (you'll notice there's no entries in the a-c table)
  • restart/try again (sometimes it might appear/sometimes you have to close the Vimeo tab and reload it)
  • if you're still not seeing the a-c entry, you'll need to restart again

Eventually https://vimeo.com/pakocampo will start appearing in the a-c list. I can reproduce this almost 100% of the time using the following build on Win 10 x64:

Brave | 1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2009 (Build 19042.685)

@zenparsing zenparsing added greaselion priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 21, 2021
@zenparsing zenparsing changed the title restart required to get media publishers added to AC Restart required to get media publishers added to AC Jan 21, 2021
@Miyayes Miyayes assigned mkarolin and unassigned szilardszaloki Apr 15, 2023
@Miyayes Miyayes added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 12, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 6, 2023

Reproduced the issue using Windows 10 x64 - 1.53.74, steps followed to reproduced the issue is mentioned below.

  • Clean profile 1.53.x
  • Enable rewards and connect custodian
  • Open few pubs like laurenwags.github.com, github.com/miyayes, alexvincentmusic.com, https://www.reddit.com/u/kjozwiak and https://www.reddit.com/user/beachbum0407
  • Stay on each publisher page for 20 to 30 sec
  • Only laurenwags.github.com and alexvincentmusic pubs got added to AC table
  • Stay on github.com/miyayes for 15 to 30 mins
  • Pubs is not added to AC table
  • Restart the browser
  • github.com/miyayes got added to AC table
  • Relaod the other publisher pages and stay on page for 10 to 15 mins
  • Pubs are not added to AC table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants