Use Greaselion for Twitch publishers

[NejcZdovc]

we should switch to GL for Twitch so that we can have faster turn around rate when something breaks.

[GeetaSarvadnya]

Verification passed on

Brave | 1.19.66 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

• Verified the test plan from Move Twitch rewards processing to Greaselion brave-core#7019
• Encountered Twitch verified pubs are Not being added to a-c table #6142 (comment)

General

• Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.27.
  
• Confirmed visiting non-verified publishers showed the generic twitch favicon in panel and AC table. Visited each of the below using a clean profile:
• Confirmed visiting verified publishers showed the verified user favicon in the panel and AC table, Tips panel, Monthly contributions, Auto contributions, and Monthly statements. Visited each of the below using a clean profile:
  https://www.twitch.tv/laurenwags/
  https://www.twitch.tv/videos/226907251
  https://www.twitch.tv/redpwnie

Twitch user URL

• Verified publisher:
  • Confirmed tip to https://www.twitch.tv/laurenwags showed on Tips panel of brave://rewards as expected
  • Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
  • Confirmed able to adjust monthly contribution amount from panel
  • Confirmed able to remove monthly contribution from panel and brave://rewards page
  • Confirmed panel, 1 time tip, recurring tip banners, AC panel, Monthly statement all had verified checkmark
• Non-verified publisher:
  • Confirmed tip to https://www.twitch.tv/jennrhim showed on pending table
  • Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
  • Confirmed able to adjust monthly contribution amount from panel
  • Confirmed able to remove monthly contribution from panel and brave://rewards page

• Custom banner:
  • Visited https://www.twitch.tv/laurenwags (on staging), confirmed custom banner was displayed
    

Brave | 1.19.75 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

Twitch video URL

• Verified publisher:
  • Confirmed tip to https://www.twitch.tv/videos/344762635 showed on Tips panel of brave://rewards as expected
  • Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
  • Confirmed able to adjust monthly contribution amount from panel
  • Confirmed able to remove monthly contribution from panel and brave://rewards page
  • Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
• Non-verified publisher:
  • Confirmed tip to https://www.twitch.tv/jennrhim/videos showed on pending table
  • Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
  • Confirmed able to adjust monthly contribution amount from panel
  • Confirmed able to remove monthly contribution from panel and brave://rewards page
    
    
    
    
    
    

Excluded URLs

Verified test plan from brave/brave-core#7019 using staging env
Confirmed example in test plan:

Spot checked other excluded URLs:

History

• Navigate to various Twitch URLs in the same tab and ensured appropriate publisher information appears in the panel
• Verified the back/forward navigation and ensured correct publisher info is shown in the panel

https://www.twitch.tv/redpwnie
https://www.twitch.tv/laurenwags
https://www.twitch.tv/videos/344762635
https://www.twitch.tv/jennrhim/videos

Tab Activation

• Navigate to various Twitch URLs in multiple tabs and ensured appropriate publisher information appears in the panel
• Verified that the correct publisher info is shown in the panel when switching between the tabs
  https://www.twitch.tv/redpwnie
  https://www.twitch.tv/laurenwags
  https://www.twitch.tv/videos/344762635
  https://www.twitch.tv/jennrhim/videos
  
  
  
  

Tipping non-Twitch Publishers

• Verify that one-time tips for unverified non-Twitch publishers are going into the pending contribution table
• Verified that one-time tips can be sent to verified non-Twitch publishers
• Verified that recurring tips for non-Twitch publishers (verified +unverified) are listed in the Monthly Contribution panel
• Verified that non-Twitch publishers are added to AC table

------------------------------

Verification in progress with

Brave	1.19.75 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	macOS Version 10.15.7 (Build 19H15)

General

• Confirmed component version:

• Twitch publishers are added to AC list, but only after browser restart. Added comment to Twitch verified pubs are Not being added to a-c table #6142 (comment)

• Encountered pre-roll ads on Twitch: pre-roll ads on twitch not always blocked #1489 (existing issue)

• Confirmed generic twitch icon for non-verified twitch publishers:

• Confirmed twitch icon for verified publishers:

• Confirmed custom icon (when configured) for verified publishers:

Twitch user URL

Verified test plan from brave/brave-core#7019 using staging env

Confirmed correct publisher info in Rewards panel for verified pub (twitch.tv/laurenwags)
Confirmed verified checkmark appears on BAT logo for verified pub.

Confirmed one time and monthly tips worked as expected for verified pub.

Confirmed correct publisher info in Rewards panel for non-verified pub (twitch.tv/chess).
Confirmed no verified checkmark appears on BAT logo for non-verified pub.

Confirmed one time tip goes to pending list for non-verified pub.

Twitch video URL

Verified test plan from brave/brave-core#7019 using staging env

Confirmed correct publisher info in Rewards panel for verified pub (https://www.twitch.tv/videos/344762635).
Confirmed verified checkmark appears on BAT logo for verified pub.

Confirmed one time and monthly tips worked as expected for verified pub.

Confirmed correct publisher info in Rewards panel for non-verified pub (https://www.twitch.tv/videos/226907251).
Confirmed no verified checkmark appears on BAT logo for non-verified pub.

Confirmed one time tip goes to pending list for non-verified pub.

Excluded URLs

Verified test plan from brave/brave-core#7019 using staging env

Confirmed example in test plan:

Spot checked other excluded URLs:

Brave	1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	macOS Version 10.15.7 (Build 19H15)

History

Verified test plan from brave/brave-core#7019

Confirmed after navigating to multiple twitch URLs in the same tab and using back/forward navigation buttons that the expected publisher information was shown

Tab Activation

Verified test plan from brave/brave-core#7019

Confirmed after navigating to multiple twitch URLs in the multiple tabs and switching between the tabs that the expected publisher information was shown.

Tipping non-Twitch Publishers

Verified test plan from brave/brave-core#7019

Confirmed that one-time tips for unverified non-Twitch publishers are going into the pending contribution table
Confirmed that one-time tips can be sent to verified non-Twitch publishers
Confirmed that recurring tips for non-Twitch publishers (verified +unverified) are listed in the Monthly Contribution panel

Pending List	One Time Tip	Monthly Tip

General

• Confirmed component version:

• Twitch publishers are added to AC list, but only after browser restart. Encountered Twitch verified pubs are Not being added to a-c table #6142 & Restart required to get media publishers added to AC #13391
  

• Confirmed generic twitch icon for non-verified twitch publishers:
  

• Confirmed twitch icon for verified publishers:
  

• Confirmed custom icon (when configured) for verified publishers:
  
  

Twitch user URL

Verified test plan from brave/brave-core#7019 using staging env

Confirmed correct publisher info in Rewards panel for verified pub (twitch.tv/laurenwags)
Confirmed verified checkmark appears on BAT logo for verified pub.

Confirmed one time and monthly tips worked as expected for verified pub.

Confirmed correct publisher info in Rewards panel for non-verified pub (twitch.tv/chess).
Confirmed no verified checkmark appears on BAT logo for non-verified pub.

Confirmed one time tip goes to pending list for non-verified pub.

Twitch video URL

Verified test plan from brave/brave-core#7019 using staging env

Confirmed correct publisher info in Rewards panel for verified pub https://www.twitch.tv/videos/344762635
Confirmed verified checkmark appears on BAT logo for verified pub.

Confirmed one time and monthly tips worked as expected for verified pub.

Confirmed correct publisher info in Rewards panel for non-verified pub (https://www.twitch.tv/videos/226907251).
Confirmed no verified checkmark appears on BAT logo for non-verified pub.

Confirmed one time tip goes to pending list for non-verified pub.

Excluded URLs

Verified test plan from brave/brave-core#7019 using staging env

Confirmed example in test plan:

Spot checked other excluded URLs:

History

Verified test plan from brave/brave-core#7019

Confirmed after navigating to multiple twitch URLs in the same tab and using back/forward navigation buttons that the expected publisher information was shown

Tab Activation

Verified test plan from brave/brave-core#7019

Confirmed after navigating to multiple twitch URLs in the multiple tabs and switching between the tabs that the expected publisher information was shown.

Tipping non-Twitch Publishers

Verified test plan from brave/brave-core#7019

Confirmed that one-time tips for unverified non-Twitch publishers are going into the pending contribution table
Confirmed that one-time tips can be sent to verified non-Twitch publishers
Confirmed that recurring tips for non-Twitch publishers (verified +unverified) are listed in the Monthly Contribution panel

Pending List	One Time Tip	Monthly Tip