-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Twitch rewards processing to Greaselion #7019
Conversation
7ff6e20
to
065fa69
Compare
065fa69
to
42ae6c9
Compare
return media_type == "github" || media_type == "reddit" || | ||
media_type == "twitter" || media_type == "vimeo" || | ||
media_type == "youtube"; | ||
media_type == "twitch" || media_type == "twitter" || | ||
media_type == "vimeo" || media_type == "youtube"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can just return true for desktop, now that all of the supported publishers use Greaselion.
@zenparsing You can probably remove the |
7ba20a4
to
a578903
Compare
a578903
to
af505f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI failed on known |
Resolves brave/brave-browser#11466
Related PR brave/brave-site-specific-scripts#26
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
Desktop
Twitch user URL
https://www.twitch.tv/laurenwags
)Twitch video URL
https://www.twitch.tv/videos/577831096
)Excluded URLs
https://www.twitch.tv/directory/game/Music
)www.twitch.tv
)History
Tab Activation
Tipping non-Twitch Publishers
Mobile
No changes were made to mobile platforms, so verify that Twitch navigation / tipping / Rewards panel continue to work as expected on those platforms.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.