-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect Twitch link in auto contribute and tips tables #4921
Comments
Issue did not reproduce with 0.66.88 on Beta:
|
Looks like twitch doesn't redirect https://www.twitch.tv/psherotv/videos/videos, but will redirect something like https://www.twitch.tv/psherotv/videos/videos/videos/videos/videos/videos. Link is still wrong, but it seems to have less of an impact. |
Reproduced on Windows
|
Additional way to reproduce: |
The issue is Reproducible on.
|
@GeetaSarvadnya this problem is on release (0.65) and all version except 68 where fix already landed |
Verification passed on
Verification passed on
Verified passed with
|
Description
When visiting a twitch page (ex. twitch.tv/psherotv), the channel is correctly added to the AC table, however the link for the channel is incorrect. The link should be https://www.twitch.tv/psherotv/videos however it is actually https://www.twitch.tv/psherotv/videos/videos. If you continue to revisit the page (either in a new tab or refresh the existing tab) another
/videos
will be appended to the link, so it's pretty easy to end up with a link like https://www.twitch.tv/psherotv/videos/videos/videos/videos/videos.This is occurring on release channel version 0.65.120 but not on 0.65.118 (currently released version).
Steps to Reproduce
Actual result:
View your AC table and hover over the entry for psherotv:
Expected result:
Link should not change when you refresh or revisit the page.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
Reproduced on macOS and Win by @kjozwiak
The text was updated successfully, but these errors were encountered: